aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorvarac <varacanero@zeromail.org>2015-03-05 09:23:05 +0100
committervarac <varacanero@zeromail.org>2015-03-05 09:23:57 +0100
commit5d25ec9d1ec77d735d393ef7cab7d1232e3d8997 (patch)
tree1c967668ba5a3662837de6ed31e28490bb262673
parent093b7701167304a28d31db7a45c51bba09e5a10a (diff)
downloadpuppet-postfix-5d25ec9d1ec77d735d393ef7cab7d1232e3d8997.tar.gz
puppet-postfix-5d25ec9d1ec77d735d393ef7cab7d1232e3d8997.tar.bz2
fix postfix::satellite class
i got this error using postfix::satellite: Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Cannot reassign variable valid_fqdn at /etc/puppet/modules/postfix/manifests/satellite.pp:32 … reassigning a variable within a given scope doesn't work in puppet see https://docs.puppetlabs.com/puppet/latest/reference/lang_variables.html#no-reassignment i still think overriding $::fqdn is not a good idea, but for now, i just want to get this class working again.
-rw-r--r--manifests/satellite.pp10
1 files changed, 5 insertions, 5 deletions
diff --git a/manifests/satellite.pp b/manifests/satellite.pp
index 739c625..45a40ad 100644
--- a/manifests/satellite.pp
+++ b/manifests/satellite.pp
@@ -21,16 +21,16 @@
# }
# }
#
+
class postfix::satellite(
$relayhost = '',
- $valid_fqdn = '',
+ $valid_fqdn = $::fqdn,
$root_mail_recipient = ''
) {
- # If $valid_fqdn exists, use it to override $fqdn
- case $valid_fqdn {
- "": { $valid_fqdn = $::fqdn }
- default: { $fqdn = "${valid_fqdn}" }
+ # If $valid_fqdn is provided, use it to override $fqdn
+ if $valid_fqdn != $::fdqn {
+ $fqdn = $valid_fqdn
}
class { 'postfix':