summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--num2bool.rb10
1 files changed, 6 insertions, 4 deletions
diff --git a/num2bool.rb b/num2bool.rb
index 0e6b7a5..2baef62 100644
--- a/num2bool.rb
+++ b/num2bool.rb
@@ -2,6 +2,8 @@
# num2bool.rb
#
+# TODO(Krzysztof Wilczynski): We probably need to approach numeric values differently ...
+
module Puppet::Parser::Functions
newfunction(:num2bool, :type => :rvalue, :doc => <<-EOS
EOS
@@ -13,20 +15,20 @@ module Puppet::Parser::Functions
number = arguments[0]
# Only numbers allowed ...
- if not number.match(/^\-?\d+$/)
- raise(Puppet::ParseError, 'num2bool(): Requires a number to work with')
+ unless number.match(/^\-?\d+$/)
+ raise(Puppet::ParseError, 'num2bool(): Requires integer to work with')
end
result = case number
when /^0$/
false
when /^\-?\d+$/
- # In Puppet numbers are often string-encoded ...
+ # Numbers in Puppet are often string-encoded which is troublesome ...
number = number.to_i
# We yield true for any positive number and false otherwise ...
number > 0 ? true : false
else
- raise(Puppet::ParseError, 'num2bool(): Unknown number format given')
+ raise(Puppet::ParseError, 'num2bool(): Unknown numeric format given')
end
return result