summaryrefslogtreecommitdiff
path: root/spec/unit
diff options
context:
space:
mode:
authorMartin Hellmich <mhellmic@gmail.com>2013-06-28 18:03:37 +0200
committerMartin Hellmich <mhellmic@gmail.com>2013-08-06 10:05:16 +0200
commit0206d367c05a7fb2c3bbd7d547e1306541acbef6 (patch)
tree023947900396ae5ac21cec0e52c570c0a0f93f9d /spec/unit
parentb975bd66aa7345a5eeb54eb79dd0f708934609f8 (diff)
downloadpuppet-stdlib-0206d367c05a7fb2c3bbd7d547e1306541acbef6.tar.gz
puppet-stdlib-0206d367c05a7fb2c3bbd7d547e1306541acbef6.tar.bz2
changed the validate_slength function to accept a min length
An optional third parameter can be given a min length. The function then only passes successfully, if all strings are in the range min_length <= string <= max_length update and fix function and unit tests the check for the minlength has to be written differently because 0 values should be possible. We now check a) if the input is convertible, and throw a ParseError and b) if the input .is_a?(Numeric) and ask for a positive number it's not as clean as for maxlength, but keeps a similar behaviour refined the error checking for the min length try to convert to Integer(args[2]) and fail, if it's not possible changed the tests accordingly to the new parameter checking
Diffstat (limited to 'spec/unit')
-rwxr-xr-xspec/unit/puppet/parser/functions/validate_slength_spec.rb14
1 files changed, 13 insertions, 1 deletions
diff --git a/spec/unit/puppet/parser/functions/validate_slength_spec.rb b/spec/unit/puppet/parser/functions/validate_slength_spec.rb
index eccf908..a870c63 100755
--- a/spec/unit/puppet/parser/functions/validate_slength_spec.rb
+++ b/spec/unit/puppet/parser/functions/validate_slength_spec.rb
@@ -26,8 +26,20 @@ describe "the validate_slength function" do
expect { scope.function_validate_slength(["moo","0"]) }.to(raise_error(Puppet::ParseError, /please pass a positive number as max_length/))
end
+ it "should raise a ParseError if argument 3 doesn't convert to a fixnum" do
+ expect { scope.function_validate_slength(["moo",2,["3"]]) }.to(raise_error(Puppet::ParseError, /Couldn't convert whatever you passed/))
+ end
+
+ it "should raise a ParseError if argument 3 converted, but to 0, e.g. a string" do
+ expect { scope.function_validate_slength(["moo",2,"monkey"]) }.to(raise_error(Puppet::ParseError, /Couldn't convert whatever you passed/))
+ end
+
it "should fail if string greater then size" do
- expect { scope.function_validate_slength(["test", 2]) }.to(raise_error(Puppet::ParseError, /It should have been less than or equal to/))
+ expect { scope.function_validate_slength(["test", 2]) }.to(raise_error(Puppet::ParseError, /It should have been between 0 and 2/))
+ end
+
+ it "should fail if the min length is larger than the max length" do
+ expect { scope.function_validate_slength(["test", 10, 15]) }.to(raise_error(Puppet::ParseError, /pass a min length that is smaller than the max/))
end
it "should fail if you pass an array of something other than strings" do