diff options
author | Jeff McCune <jeff@puppetlabs.com> | 2012-07-19 16:14:37 -0700 |
---|---|---|
committer | Jeff McCune <jeff@puppetlabs.com> | 2012-07-19 16:24:57 -0700 |
commit | 8a4e115ccb14d409878d46d456cc9b93fdc24867 (patch) | |
tree | e7c706007de1e1b708ff5c9c1a68b49b570c72d0 /spec/unit/puppet/parser/functions/squeeze_spec.rb | |
parent | f604bae98cb377b6fc55185d4eeae05d1c7876d2 (diff) | |
download | puppet-stdlib-8a4e115ccb14d409878d46d456cc9b93fdc24867.tar.gz puppet-stdlib-8a4e115ccb14d409878d46d456cc9b93fdc24867.tar.bz2 |
(Maint) use PuppetlabsSpec::PuppetSeams.parser_scope
Without this patch all of the spec tests for parser functions in stdlib
would instantiate their own scope instances. This is a problem because
the standard library is tightly coupled with the internal behavior of
Puppet. Tight coupling like this creates failures when we change the
internal behavior of Puppet. This is exactly what happened recently
when we changed the method signature for the initializer of
Puppet::Parser::Scope instances.
This patch fixes the problem by creating scope instances using the
puppet labs spec helper. The specific method that provides scope
instances in Puppet-version-independent way is something like this:
let(:scope) { PuppetlabsSpec::PuppetSeams.parser_scope }
This patch simply implements this across the board.
Diffstat (limited to 'spec/unit/puppet/parser/functions/squeeze_spec.rb')
-rw-r--r-- | spec/unit/puppet/parser/functions/squeeze_spec.rb | 15 |
1 files changed, 4 insertions, 11 deletions
diff --git a/spec/unit/puppet/parser/functions/squeeze_spec.rb b/spec/unit/puppet/parser/functions/squeeze_spec.rb index 4e84c12..8acec64 100644 --- a/spec/unit/puppet/parser/functions/squeeze_spec.rb +++ b/spec/unit/puppet/parser/functions/squeeze_spec.rb @@ -2,30 +2,23 @@ require 'spec_helper' describe "the squeeze function" do - before :all do - Puppet::Parser::Functions.autoloader.loadall - end - - before :each do - @scope = Puppet::Parser::Scope.new - end + let(:scope) { PuppetlabsSpec::PuppetSeams.parser_scope } it "should exist" do Puppet::Parser::Functions.function("squeeze").should == "function_squeeze" end it "should raise a ParseError if there is less than 2 arguments" do - lambda { @scope.function_squeeze([]) }.should( raise_error(Puppet::ParseError)) + lambda { scope.function_squeeze([]) }.should( raise_error(Puppet::ParseError)) end it "should squeeze a string" do - result = @scope.function_squeeze(["aaabbbbcccc"]) + result = scope.function_squeeze(["aaabbbbcccc"]) result.should(eq('abc')) end it "should squeeze all elements in an array" do - result = @scope.function_squeeze([["aaabbbbcccc","dddfff"]]) + result = scope.function_squeeze([["aaabbbbcccc","dddfff"]]) result.should(eq(['abc','df'])) end - end |