diff options
author | Leonardo Rodrigues de Mello <l@lmello.eu.org> | 2013-09-06 10:53:47 -0300 |
---|---|---|
committer | Leonardo Rodrigues de Mello <l@lmello.eu.org> | 2013-09-16 10:03:20 -0300 |
commit | 30e994fb6eb91e25a77e60a849f795d60c11af4b (patch) | |
tree | 3ef170c125734efa71decc06ab54e34efee75e45 /spec/unit/puppet/parser/functions/is_string_spec.rb | |
parent | 806430224ad0da860be3761ab83f1e574b64fc60 (diff) | |
download | puppet-stdlib-30e994fb6eb91e25a77e60a849f795d60c11af4b.tar.gz puppet-stdlib-30e994fb6eb91e25a77e60a849f795d60c11af4b.tar.bz2 |
enhanced the error message of pick function.
When pick function fail return a better error message like
the other stdlib functions, indicating that the error
is on function pick.
This would help people that see the error to identity it is
related to a incorrect use of stdlib function pick, instead of having
to grep all puppet libraries and manifests source for the old message.
I had also changed the spec test.
pick function change spec as suggested GH-179
Fix the spec test to use expect {}.to instead of lambda {}.should
as explained by Adrienthebo.
"Using expect { }.to is preferred over lambda { }.should.
In addition it's best practice to do a string match against the
error message to ensure that we're catching the right error,
instead of any error of the right type."
Also fixed a typo on the error message, it was missing one space.
pick function stylish fix as suggested on GH179
Diffstat (limited to 'spec/unit/puppet/parser/functions/is_string_spec.rb')
0 files changed, 0 insertions, 0 deletions