finish refactoring

refactor everything towards class parameters and also add enable
class for lastlog

2 files changed, 18 insertions, 9 deletions

diff --git a/manifests/lastlog/disable.pp b/manifests/lastlog/disable.pp
index 519195f..e143477 100644
--- a/manifests/lastlog/disable.pp
+++ b/manifests/lastlog/disable.pp
@@ -1,13 +1,9 @@
-class loginrecords::lastlog::disable(
-  $pam_login_file = '/etc/pam.d/login'
-){
-  replace { 'loginrecords-lastlog-disable':
-    file    => $pam_login_file,
+class loginrecords::lastlog::disable inherits loginrecords::lastlog::enable {
+  Replace['loginrecords-lastlog']{
     pattern   => '^session[[:space:]]+optional[[:space:]]+pam_lastlog.so$',
     replacement => '#session  optional   pam_lastlog.so',
   }
-  file{'/var/log/lastlog':
-    content => '',
-    owner => root, group => utmp, mode => 0664;
-  } 
+  File['/var/log/lastlog']{
+    ensure => absent,
+  }
 }
diff --git a/manifests/lastlog/enable.pp b/manifests/lastlog/enable.pp
new file mode 100644
index 0000000..bd9378b
--- /dev/null
+++ b/manifests/lastlog/enable.pp
@@ -0,0 +1,13 @@
+class loginrecords::lastlog::enable(
+  $pam_login_file = '/etc/pam.d/login'
+){
+  replace{'loginrecords-lastlog':
+    file => $pam_login_file,
+    pattern   => '^#session[[:space:]]+optional[[:space:]]+pam_lastlog.so$',
+    replacement => 'session  optional   pam_lastlog.so',
+  }
+  file{'/var/log/lastlog':
+    ensure => present,
+    owner => root, group => utmp, mode => 0664;
+  }
+}