introduce class parameters to make the interface nicer

3 files changed, 16 insertions, 24 deletions

diff --git a/README b/README
index 94571ec..777aae7 100644
--- a/README
+++ b/README
@@ -16,6 +16,10 @@ Dependencies
 Configuration
 =============
 
+You can set the following parameters for the loginrecords class.
+If you just include the class loginrecords this will disable all
+loginlogs.
+
 $disable_btmp, $disable_utmp, $disable_wtmp
 -------------------------------------------
 
diff --git a/manifests/debian.pp b/manifests/debian.pp
index cd729d6..56c5dca 100644
--- a/manifests/debian.pp
+++ b/manifests/debian.pp
@@ -6,29 +6,29 @@ class loginrecords::debian inherits loginrecords::base {
     $utmp_file       = '/var/run/utmp'
     $wtmp_file       = '/var/log/wtmp'
 
-    if $disable_btmp {
+    if $loginrecords::disable_btmp {
         include loginrecords::btmp::disable
     } else {
         include loginrecords::btmp::enable
     }
 
-    if $disable_faillog {
+    if $loginrecords::disable_faillog {
         include loginrecords::faillog::disable
     } else {
         include loginrecords::faillog::enable
     }
 
-    if $disable_lastlog {
+    if $loginrecords::disable_lastlog {
         include loginrecords::lastlog::disable
     }
 
-    if $disable_utmp {
+    if $loginrecords::disable_utmp {
         include loginrecords::utmp::disable
     } else {
         include loginrecords::utmp::enable
     }
 
-    if $disable_wtmp {
+    if $loginrecords::disable_wtmp {
         include loginrecords::wtmp::disable
     } else {
         include loginrecords::wtmp::enable
diff --git a/manifests/init.pp b/manifests/init.pp
index 3bcf274..9c0a880 100644
--- a/manifests/init.pp
+++ b/manifests/init.pp
@@ -1,22 +1,10 @@
-class loginrecords {
-
-    # Default settings
-    if $disable_btmp == '' {
-        $disable_btmp = true
-    }
-    if $disable_faillog == '' {
-        $disable_faillog = true
-    }
-    if $disable_lastlog == '' {
-        $disable_lastlog = true
-    }
-    if $disable_utmp == '' {
-        $disable_utmp = true
-    }
-    if $disable_wtmp == '' {
-        $disable_wtmp = true
-    }
-
+class loginrecords(
+    $disable_btmp = true,
+    $disable_faillog = true,
+    $disable_lastlog = true,
+    $disable_utmp = true,
+    $disable_wtmp = true
+){
     # Include main class
     case $kernel {
         "Linux": {