Repair Exec['update_apt'] to run apt-get update when needed.

Move this Exec to a dedicated class that is not included by default i.e. we
default not to "apt-get update" on every Puppet run.

We now make use of this class in the apt::upgrade_package define to make sure
APT indexes are up-to-date before attempting package upgrades.

One may now use the following to ensure current packages are installed by
Package resources:

  include apt::update
  Package { require => Exec[apt_updated] }

1 files changed, 0 insertions, 9 deletions

diff --git a/manifests/init.pp b/manifests/init.pp
index 8a4a0a5..b5be91f 100644
--- a/manifests/init.pp
+++ b/manifests/init.pp
@@ -142,15 +142,6 @@ class apt {
       command => '/usr/bin/apt-get update && sleep 1',
       refreshonly => true,
       subscribe => [ File['/etc/apt/apt.conf.d'], Config_file['/etc/apt/sources.list'] ];
-
-    'update_apt':
-      command => '/usr/bin/apt-get update && /usr/bin/apt-get autoclean',
-      refreshonly => true,
-      require => [ File['/etc/apt/apt.conf.d', '/etc/apt/preferences' ],
-                   Config_file['/etc/apt/sources.list'] ],
-      loglevel => info,
-      # Another Semaphor for all packages to reference
-      alias => "apt_updated";
   }
 
   ## This package should really always be current