1 files changed, 36 insertions, 35 deletions
diff --git a/actions/plugins/settings/save.php b/actions/plugins/settings/save.php
index 574b98ef2..581a2f9ec 100644
--- a/actions/plugins/settings/save.php
+++ b/actions/plugins/settings/save.php
@@ -1,42 +1,43 @@
 <?php
-	/**
-	 * Elgg plugin settings save action.
-	 * 
-	 * @package Elgg
-	 * @subpackage Core
-	 * @license http://www.gnu.org/licenses/old-licenses/gpl-2.0.html GNU Public License version 2
-	 * @author Curverider Ltd
-	 * @copyright Curverider Ltd 2008-2009
-	 * @link http://elgg.org/
-	 */
+/**
+ * Saves global plugin settings.
+ *
+ * This action can be overriden for a specific plugin by creating the
+ * <plugin_id>/settings/save action in that plugin.
+ *
+ * @uses array $_REQUEST['params']    A set of key/value pairs to save to the ElggPlugin entity
+ * @uses int   $_REQUEST['plugin_id'] The ID of the plugin
+ *
+ * @package Elgg.Core
+ * @subpackage Plugins.Settings
+ */
 
-	$params = get_input('params');
-	$plugin = get_input('plugin');
+$params = get_input('params');
+$plugin_id = get_input('plugin_id');
+$plugin = elgg_get_plugin_from_id($plugin_id);
 
-	gatekeeper();
-	action_gatekeeper();
-	
-	$result = false;
-	
-	foreach ($params as $k => $v)
-	{
-		// Save
-		$result = set_plugin_setting($k, $v, $plugin);
-		
-		// Error?
-		if (!$result)
-		{
-			register_error(sprintf(elgg_echo('plugins:settings:save:fail'), $plugin));
-			
-			forward($_SERVER['HTTP_REFERER']);
-			
+if (!($plugin instanceof ElggPlugin)) {
+	register_error(elgg_echo('plugins:settings:save:fail', array($plugin_id)));
+	forward(REFERER);
+}
+
+$plugin_name = $plugin->getManifest()->getName();
+
+$result = false;
+
+// allow a plugin to override the save action for their settings
+if (elgg_action_exists("$plugin_id/settings/save")) {
+	action("$plugin_id/settings/save");
+} else {
+	foreach ($params as $k => $v) {
+		$result = $plugin->setSetting($k, $v);
+		if (!$result) {
+			register_error(elgg_echo('plugins:settings:save:fail', array($plugin_name)));
+			forward(REFERER);
 			exit;
 		}
 	}
+}
 
-	// An event to tell any interested plugins of the change is settings
-	//trigger_elgg_event('plugin_settings_save', $plugin, find_plugin_settings($plugin)); // replaced by plugin:setting event
-	
-	system_message(sprintf(elgg_echo('plugins:settings:save:ok'), $plugin));
-	forward($_SERVER['HTTP_REFERER']);
-?>
-\ No newline at end of file
+system_message(elgg_echo('plugins:settings:save:ok', array($plugin_name)));
+forward(REFERER);
+\ No newline at end of file