uploading photos through the basic interface works now

2 files changed, 63 insertions, 32 deletions

diff --git a/pages/photos/image/thumbnail.php b/pages/photos/image/thumbnail.php
new file mode 100644
index 000000000..ae07f2706
--- /dev/null
+++ b/pages/photos/image/thumbnail.php
@@ -0,0 +1,34 @@
+<?php
+/**
+ * Image thumbnail view
+ *
+ * @author Cash Costello
+ * @license http://www.gnu.org/licenses/gpl-2.0.html GNU General Public License v2
+ */
+
+$guid = (int) get_input('guid');
+$size = get_input('size');
+$image = get_entity($guid);
+if (!$image) {
+	// @todo
+}
+
+$contents = $image->getThumbnail($size);
+if (!$contents) {
+	forward("mod/tidypics/graphics/image_error_$size");
+}
+
+// expires every 14 days
+$expires = 14 * 60*60*24;
+
+// overwrite header caused by php session code so images can be cached
+$mime = $image->getMimeType();
+header("Content-Type: $mime");
+header("Content-Length: " . strlen($contents));
+header("Cache-Control: public", true);
+header("Pragma: public", true);
+header('Expires: ' . gmdate('D, d M Y H:i:s', time() + $expires) . ' GMT', true);
+
+// Return the thumbnail and exit
+echo $contents;
+exit;
diff --git a/pages/photos/image/upload.php b/pages/photos/image/upload.php
index 6580c6f52..526972a35 100644
--- a/pages/photos/image/upload.php
+++ b/pages/photos/image/upload.php
@@ -1,62 +1,59 @@
 <?php
 /**
- * Tidypics Upload Images Page
+ * Upload images
  *
+ * @author Cash Costello
+ * @license http://www.gnu.org/licenses/gpl-2.0.html GNU General Public License v2
  */
 
-include_once dirname(dirname(dirname(dirname(__FILE__)))) . "/engine/start.php";
-
-global $CONFIG;
-
-// must be logged in to upload images
 gatekeeper();
 
-$album_guid = (int) get_input('album_guid');
+$album_guid = (int) get_input('guid');
 if (!$album_guid) {
+	// @todo
 	forward();
 }
 
-if (get_plugin_setting('uploader', 'tidypics') != "disabled") {
+if (elgg_get_plugin_setting('uploader', 'tidypics') != "disabled") {
 	$uploader = get_input('uploader', 'ajax');
 } else {
 	$uploader = 'basic';
 }
 
-
 $album = get_entity($album_guid);
-
-//if album does not exist or user does not have access
 if (!$album || !$album->canEdit()) {
+	// @todo
 	// throw warning and forward to previous page
-	forward($_SERVER['HTTP_REFERER']);
+	forward(REFERER);
+}
+
+if (!$album->canEdit()) {
+	// @todo have to be able to edit album to upload photos
 }
 
 // set page owner based on container (user or group)
-set_page_owner($album->container_guid);
+elgg_set_page_owner_guid($album->getContainerGUID());
+$owner = elgg_get_page_owner_entity();
 
-$page_owner = page_owner_entity();
-if ($page_owner instanceof ElggGroup) {
-	add_submenu_item(	sprintf(elgg_echo('album:group'),$page_owner->name),
-			$CONFIG->wwwroot . "pg/photos/owned/" . $page_owner->username);
-}
+$title = elgg_echo('album:addpix');
 
-set_context('photos');
-$title = elgg_echo('album:addpix') . ': ' . $album->title;
-$area2 .= elgg_view_title($title);
+// set up breadcrumbs
+elgg_push_breadcrumb(elgg_echo('photos'), "photos/all");
+elgg_push_breadcrumb($owner->name, "photos/owner/$owner->username");
+elgg_push_breadcrumb($album->getTitle(), $album->getURL());
+elgg_push_breadcrumb(elgg_echo('album:addpix'));
 
-if ($uploader == 'basic') {
-	$area2 .= elgg_view('input/form', array(
-		'action' => "{$CONFIG->wwwroot}action/tidypics/upload",
-		'body' => elgg_view('forms/tidypics/basic_upload', array('album' => $album)),
-		'internalid' => 'tidypicsUpload',
-		'enctype' => 'multipart/form-data',
-		'method' => 'post',
-	));
 
+if ($uploader == 'basic') {
+	$content = elgg_view('forms/photos/basic_upload', array('entity' => $album));
 } else {
-	$area2 .= elgg_view("forms/tidypics/ajax_upload", array('album' => $album));
+	$content = elgg_view('forms/photos/ajax_upload', array('entity' => $album));
 }
 
-$body = elgg_view_layout('two_column_left_sidebar', '', $area2);
+$body = elgg_view_layout('content', array(
+	'content' => $content,
+	'title' => $title,
+	'filter' => '',
+));
 
-page_draw($title, $body);
+echo elgg_view_page($title, $body);