aboutsummaryrefslogtreecommitdiff
path: root/mod/developers
diff options
context:
space:
mode:
authorcash <cash.costello@gmail.com>2013-03-21 19:47:08 -0400
committercash <cash.costello@gmail.com>2013-03-21 19:47:08 -0400
commite757ad0cffd35507d6430b8635e2b934db58650f (patch)
tree2ce6d60c4ce719134e674d3bd42ebbd2746ea6f6 /mod/developers
parentea5cb2677411bf9f0307d650399a848c4c8e208d (diff)
downloadelgg-e757ad0cffd35507d6430b8635e2b934db58650f.tar.gz
elgg-e757ad0cffd35507d6430b8635e2b934db58650f.tar.bz2
Fixes #5268 adds warning for wrapping views
Diffstat (limited to 'mod/developers')
-rw-r--r--mod/developers/languages/en.php3
-rw-r--r--mod/developers/start.php9
2 files changed, 11 insertions, 1 deletions
diff --git a/mod/developers/languages/en.php b/mod/developers/languages/en.php
index 856efe008..266b5406e 100644
--- a/mod/developers/languages/en.php
+++ b/mod/developers/languages/en.php
@@ -28,7 +28,8 @@ $english = array(
'developers:label:show_strings' => "Show raw translation strings",
'developers:help:show_strings' => "This displays the translation strings used by elgg_echo().",
'developers:label:wrap_views' => "Wrap views",
- 'developers:help:wrap_views' => "This wraps almost every view with HTML comments. Useful for finding the view creating particular HTML.",
+ 'developers:help:wrap_views' => "This wraps almost every view with HTML comments. Useful for finding the view creating particular HTML.
+ This can break non-HTML views in the default viewtype. See developers_wrap_views() for details.",
'developers:label:log_events' => "Log events and plugin hooks",
'developers:help:log_events' => "Write events and plugin hooks to the log. Warning: there are many of these per page.",
diff --git a/mod/developers/start.php b/mod/developers/start.php
index 413a8ed9b..94d0f652c 100644
--- a/mod/developers/start.php
+++ b/mod/developers/start.php
@@ -89,6 +89,15 @@ function developers_clear_strings() {
/**
* Post-process a view to add wrapper comments to it
+ *
+ * 1. Only process views served with the 'default' viewtype.
+ * 2. Does not wrap views that begin with js/ or css/ as they are not HTML.
+ * 3. Does not wrap views that are images (start with icon/). Is this still true?
+ * 4. Does not wrap input and output views (why?).
+ * 5. Does not wrap html head or the primary page shells
+ *
+ * @warning this will break views in the default viewtype that return non-HTML data
+ * that do not match the above restrictions.
*/
function developers_wrap_views($hook, $type, $result, $params) {
if (elgg_get_viewtype() != "default") {