first go at brining tidypics up to code standards

1 files changed, 70 insertions, 65 deletions

diff --git a/actions/settings.php b/actions/settings.php
index a4f102b89..2c529d950 100644
--- a/actions/settings.php
+++ b/actions/settings.php
@@ -1,72 +1,77 @@
 <?php
-	/**
-	 * Save settings of Tidypics
-	 * 
-	 */
+/**
+ * Save settings of Tidypics
+ *
+ */
 
-	global $CONFIG;
+global $CONFIG;
 
-	admin_gatekeeper();
-	action_gatekeeper();
+admin_gatekeeper();
+action_gatekeeper();
 
 
-	// Params array (text boxes and drop downs)
-	$params = get_input('params');
-	$result = false;
-	foreach ($params as $k => $v) {
-		if (!set_plugin_setting($k, $v, 'tidypics')) {
-			register_error(sprintf(elgg_echo('plugins:settings:save:fail'), 'tidypics'));
-			forward($_SERVER['HTTP_REFERER']);
-		}
+// Params array (text boxes and drop downs)
+$params = get_input('params');
+$result = false;
+foreach ($params as $k => $v) {
+	if (!set_plugin_setting($k, $v, 'tidypics')) {
+		register_error(sprintf(elgg_echo('plugins:settings:save:fail'), 'tidypics'));
+		forward($_SERVER['HTTP_REFERER']);
 	}
+}
 
-	// check boxes
-	if (is_array(get_input('download_link'))) // this can be done due to way Elgg uses checkboxes
-		set_plugin_setting('download_link', 'enabled', 'tidypics');
-	else
-		set_plugin_setting('download_link', 'disabled', 'tidypics');
-
-	if (is_array(get_input('tagging')))
-		set_plugin_setting('tagging', 'enabled', 'tidypics');
-	else
-		set_plugin_setting('tagging', 'disabled', 'tidypics');
-
-	if (is_array(get_input('photo_ratings')))
-		set_plugin_setting('photo_ratings', 'enabled', 'tidypics');
-	else
-		set_plugin_setting('photo_ratings', 'disabled', 'tidypics');
-
-	if (is_array(get_input('exif')))
-		set_plugin_setting('exif', 'enabled', 'tidypics');
-	else
-		set_plugin_setting('exif', 'disabled', 'tidypics');
-
-	if (is_array(get_input('view_count')))
-		set_plugin_setting('view_count', 'enabled', 'tidypics');
-	else
-		set_plugin_setting('view_count', 'disabled', 'tidypics');
-
-	if (is_array(get_input('grp_perm_override')))
-		set_plugin_setting('grp_perm_override', 'enabled', 'tidypics');
-	else
-		set_plugin_setting('grp_perm_override', 'disabled', 'tidypics');
-
-
-	// image sizes
-	$image_sizes = array();
-	$image_sizes['large_image_width'] = get_input('large_thumb_width');
-	$image_sizes['large_image_height'] = get_input('large_thumb_height');
-	$image_sizes['small_image_width'] = get_input('small_thumb_width');
-	//$image_sizes['small_image_height'] = get_input('small_thumb_height');
-	$image_sizes['small_image_height'] = get_input('small_thumb_width');
-	$image_sizes['thumb_image_width'] = get_input('thumb_width');
-	//$image_sizes['thumb_image_height'] = get_input('thumb_height');
-	$image_sizes['thumb_image_height'] = get_input('thumb_width');
-	set_plugin_setting('image_sizes', serialize($image_sizes), 'tidypics');
-
-
-	
-	system_message(elgg_echo('tidypics:settings:save:ok'));
-	
-	forward($_SERVER['HTTP_REFERER']);
-?>
+// check boxes
+if (is_array(get_input('download_link'))) { // this can be done due to way Elgg uses checkboxes
+	set_plugin_setting('download_link', 'enabled', 'tidypics');
+} else {
+	set_plugin_setting('download_link', 'disabled', 'tidypics');
+}
+
+if (is_array(get_input('tagging'))) {
+	set_plugin_setting('tagging', 'enabled', 'tidypics');
+} else {
+	set_plugin_setting('tagging', 'disabled', 'tidypics');
+}
+
+if (is_array(get_input('photo_ratings'))) {
+	set_plugin_setting('photo_ratings', 'enabled', 'tidypics');
+} else {
+	set_plugin_setting('photo_ratings', 'disabled', 'tidypics');
+}
+
+if (is_array(get_input('exif'))) {
+	set_plugin_setting('exif', 'enabled', 'tidypics');
+} else {
+	set_plugin_setting('exif', 'disabled', 'tidypics');
+}
+
+if (is_array(get_input('view_count'))) {
+	set_plugin_setting('view_count', 'enabled', 'tidypics');
+} else {
+	set_plugin_setting('view_count', 'disabled', 'tidypics');
+}
+
+if (is_array(get_input('grp_perm_override'))) {
+	set_plugin_setting('grp_perm_override', 'enabled', 'tidypics');
+} else {
+	set_plugin_setting('grp_perm_override', 'disabled', 'tidypics');
+}
+
+
+// image sizes
+$image_sizes = array();
+$image_sizes['large_image_width'] = get_input('large_thumb_width');
+$image_sizes['large_image_height'] = get_input('large_thumb_height');
+$image_sizes['small_image_width'] = get_input('small_thumb_width');
+//$image_sizes['small_image_height'] = get_input('small_thumb_height');
+$image_sizes['small_image_height'] = get_input('small_thumb_width');
+$image_sizes['thumb_image_width'] = get_input('thumb_width');
+//$image_sizes['thumb_image_height'] = get_input('thumb_height');
+$image_sizes['thumb_image_height'] = get_input('thumb_width');
+set_plugin_setting('image_sizes', serialize($image_sizes), 'tidypics');
+
+
+
+system_message(elgg_echo('tidypics:settings:save:ok'));
+
+forward($_SERVER['HTTP_REFERER']);