Fixes #4131 elgg_delete_metastring_based_object_by_id() should return a bool

2 files changed, 2 insertions, 2 deletions

diff --git a/engine/lib/metastrings.php b/engine/lib/metastrings.php
index 9dccec700..9fe9b4bff 100644
--- a/engine/lib/metastrings.php
+++ b/engine/lib/metastrings.php
@@ -810,7 +810,7 @@ function elgg_delete_metastring_based_object_by_id($id, $type) {
 		}
 
 		if (($obj->canEdit()) && (elgg_trigger_event('delete', $type, $obj))) {
-			return delete_data("DELETE from $table where id=$id");
+			return (bool)delete_data("DELETE from $table where id=$id");
 		}
 	}
 
diff --git a/engine/tests/api/metastrings.php b/engine/tests/api/metastrings.php
index 0a008c6ce..f6870d34b 100644
--- a/engine/tests/api/metastrings.php
+++ b/engine/tests/api/metastrings.php
@@ -80,7 +80,7 @@ class ElggCoreMetastringsTest extends ElggCoreUnitTest {
 			$test = get_data($q);
 
 			$this->assertEqual($test[0]->id, $id);
-			$this->assertTrue(elgg_delete_metastring_based_object_by_id($id, $type));
+			$this->assertIdentical(true, elgg_delete_metastring_based_object_by_id($id, $type));
 			$this->assertFalse(get_data($q));
 		}
 	}