From 26352761d3d1920390b0ba6d133543f3b83674a5 Mon Sep 17 00:00:00 2001 From: Christian Weiske Date: Thu, 21 Mar 2013 06:49:37 +0100 Subject: The hasTag was always returning false, which probably is a bug. Fixed it and added a test to catch it. Thanks for Ricardo Soares de Lima for the first patch version --- tests/Bookmark2TagTest.php | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) (limited to 'tests') diff --git a/tests/Bookmark2TagTest.php b/tests/Bookmark2TagTest.php index fdfc42e..76390d9 100644 --- a/tests/Bookmark2TagTest.php +++ b/tests/Bookmark2TagTest.php @@ -88,7 +88,7 @@ class Bookmark2TagTest extends TestBase $this->b2ts->getTagsForBookmark($bid, true) ); } - + public function testAttachTagsWithEmptyStringAddsSystemUnfiled() { $originalDisplayErros = ini_get('display_errors'); @@ -582,7 +582,7 @@ class Bookmark2TagTest extends TestBase $this->addBookmark($user1, null, 0, array('usertag')); $GLOBALS['admin_users'] = array('admin1', 'admin2'); - + $arTags = $this->b2ts->getAdminTags(4); $this->assertEquals(3, count($arTags)); $this->assertContains(array('tag' => 'admintag', 'bCount' => '2'), $arTags); @@ -600,7 +600,7 @@ class Bookmark2TagTest extends TestBase $this->addBookmark($admin1, null, 0, array('tester', 'testos')); $GLOBALS['admin_users'] = array('admin1'); - + $arTags = $this->b2ts->getAdminTags(4, null, null, 'test'); $this->assertEquals(2, count($arTags)); $this->assertContains(array('tag' => 'tester', 'bCount' => '1'), $arTags); @@ -675,5 +675,14 @@ class Bookmark2TagTest extends TestBase $this->assertContains(array('tag' => 'usertag1', 'bCount' => '1'), $arTags); $this->assertContains(array('tag' => 'usable', 'bCount' => '2'), $arTags); } + + public function testHasTag() + { + $bid = $this->addBookmark(null, null, 0, array('foo')); + + $this->assertTrue($this->b2ts->hasTag($bid, 'foo')); + $this->assertFalse($this->b2ts->hasTag($bid, 'bar')); + + } } ?> -- cgit v1.2.3