From 24ab0f6487d7a3883af126cc22f5d9d08acf3a80 Mon Sep 17 00:00:00 2001 From: mensonge Date: Thu, 15 Jan 2009 18:05:08 +0000 Subject: Minor Refactoring: add getIdFromUser() git-svn-id: https://semanticscuttle.svn.sourceforge.net/svnroot/semanticscuttle/trunk@238 b3834d28-1941-0410-a4f8-b48e95affb8f --- profile.php | 151 ++++++++++++++++++++++++++++++------------------------------ 1 file changed, 76 insertions(+), 75 deletions(-) (limited to 'profile.php') diff --git a/profile.php b/profile.php index 56d6515..2d00101 100644 --- a/profile.php +++ b/profile.php @@ -1,23 +1,23 @@ getObjectUserByUsername($user); - if ($userinfo == '') { - $tplVars['error'] = sprintf(T_('User with username %s was not found'), $user); - $templateservice->loadTemplate('error.404.tpl', $tplVars); - exit(); - } else { - $userid =& $userinfo->getId(); - } - } + + if (is_int($user)) { + $userid = intval($user); + } else { + $user = urldecode($user); + $userinfo = $userservice->getObjectUserByUsername($user); + if ($userinfo == NULL) { + $tplVars['error'] = sprintf(T_('User with username %s was not found'), $user); + $templateservice->loadTemplate('error.404.tpl', $tplVars); + exit(); + } else { + $userid =& $userinfo->getId(); + } + } } else { - $tplVars['error'] = T_('Username was not specified'); - $templateservice->loadTemplate('error.404.tpl', $tplVars); - exit(); + $tplVars['error'] = T_('Username was not specified'); + $templateservice->loadTemplate('error.404.tpl', $tplVars); + exit(); } if ($userservice->isLoggedOn() && $user == $currentUser->getUsername()) { - $title = T_('My Profile'); + $title = T_('My Profile'); } else { - $title = T_('Profile') .': '. $user; + $title = T_('Profile') .': '. $user; } $tplVars['pagetitle'] = $title; $tplVars['subtitle'] = $title; @@ -72,55 +73,55 @@ $tplVars['user'] = $user; $tplVars['userid'] = $userid; if (POST_SUBMITTED!='' && $currentUser->getId() == $userid) { - $error = false; - $detPass = trim(POST_PASS); - $detPassConf = trim(POST_PASSCONF); - $detName = trim(POST_NAME); - $detMail = trim(POST_MAIL); - $detPage = trim(POST_PAGE); - $detDesc = filter(POST_DESC); - - // manage token preventing from CSRF vulnaribilities - if ( SESSION_TOKEN == '' - || time() - SESSION_TOKENSTAMP > 600 //limit token lifetime, optionnal - || SESSION_TOKEN != POST_TOKEN) { - $error = true; - $tplVars['error'] = T_('Invalid Token'); - } - - if ($detPass != $detPassConf) { - $error = true; - $tplVars['error'] = T_('Password and confirmation do not match.'); - } - if ($detPass != "" && strlen($detPass) < 6) { - $error = true; - $tplVars['error'] = T_('Password must be at least 6 characters long.'); - } - if (!$userservice->isValidEmail($detMail)) { - $error = true; - $tplVars['error'] = T_('E-mail address is not valid.'); - } - if (!$error) { - if (!$userservice->updateUser($userid, $detPass, $detName, $detMail, $detPage, $detDesc)) { - $tplvars['error'] = T_('An error occurred while saving your changes.'); - } else { - $tplVars['msg'] = T_('Changes saved.'); - } - } - $userinfo = $userservice->getObjectUserByUsername($user); + $error = false; + $detPass = trim(POST_PASS); + $detPassConf = trim(POST_PASSCONF); + $detName = trim(POST_NAME); + $detMail = trim(POST_MAIL); + $detPage = trim(POST_PAGE); + $detDesc = filter(POST_DESC); + + // manage token preventing from CSRF vulnaribilities + if ( SESSION_TOKEN == '' + || time() - SESSION_TOKENSTAMP > 600 //limit token lifetime, optionnal + || SESSION_TOKEN != POST_TOKEN) { + $error = true; + $tplVars['error'] = T_('Invalid Token'); + } + + if ($detPass != $detPassConf) { + $error = true; + $tplVars['error'] = T_('Password and confirmation do not match.'); + } + if ($detPass != "" && strlen($detPass) < 6) { + $error = true; + $tplVars['error'] = T_('Password must be at least 6 characters long.'); + } + if (!$userservice->isValidEmail($detMail)) { + $error = true; + $tplVars['error'] = T_('E-mail address is not valid.'); + } + if (!$error) { + if (!$userservice->updateUser($userid, $detPass, $detName, $detMail, $detPage, $detDesc)) { + $tplvars['error'] = T_('An error occurred while saving your changes.'); + } else { + $tplVars['msg'] = T_('Changes saved.'); + } + } + $userinfo = $userservice->getObjectUserByUsername($user); } if (!$userservice->isLoggedOn() || $currentUser->getId() != $userid) { - $templatename = 'profile.tpl.php'; + $templatename = 'profile.tpl.php'; } else { //Token Init $_SESSION['token'] = md5(uniqid(rand(), true)); $_SESSION['token_stamp'] = time(); - - $templatename = 'editprofile.tpl.php'; - $tplVars['formaction'] = createURL('profile', $user); - $tplVars['token'] = $_SESSION['token']; - + + $templatename = 'editprofile.tpl.php'; + $tplVars['formaction'] = createURL('profile', $user); + $tplVars['token'] = $_SESSION['token']; + } $tplVars['objectUser'] = $userinfo; -- cgit v1.2.3