From 726746649e38615b69aa372ec978b2ffa39b89d5 Mon Sep 17 00:00:00 2001 From: Krzysztof Wilczynski Date: Fri, 29 Apr 2011 23:18:58 +0100 Subject: Small re-factor. Changed if not to unless for code clarity. Signed-off-by: Krzysztof Wilczynski --- capitalize.rb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/capitalize.rb b/capitalize.rb index 74d4f28..ac6cc50 100644 --- a/capitalize.rb +++ b/capitalize.rb @@ -13,12 +13,13 @@ module Puppet::Parser::Functions value = arguments[0] klass = value.class - if not [Array, String].include?(klass) - raise(Puppet::ParseError, 'capitalize(): Requires either an ' + + unless [Array, String].include?(klass) + raise(Puppet::ParseError, 'capitalize(): Requires either ' + 'array or string to work with') end if value.is_a?(Array) + # Numbers in Puppet are often string-encoded ... result = value.collect { |i| i.is_a?(String) ? i.capitalize : i } else result = value.capitalize -- cgit v1.2.3