summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-01-08Test certificate and key with a truncated middleMatt Bostock
Test a valid certificate and valid key that have had 48 characters removed from their middle, to simulate a malformed certificate and key. Suggested by @DavidS in https://github.com/puppetlabs/puppetlabs-stdlib/pull/552
2016-01-08Add a function to validate an x509 RSA key pairMatt Bostock
Add a function to validate an x509 RSA certificate and key pair, as commonly used for TLS certificates. The rationale behind this is that we store our TLS certificates and private keys in Hiera YAML files, and poor indentation or formatting in the YAML file could cause a valid certificate to be considered invalid. Will cause the Puppet run to fail if: - an invalid certificate is detected - an invalid RSA key is detected - the certificate does not match the key, i.e. the certificate has not been signed by the supplied key The test certificates I've used in the spec tests were generated using the Go standard library: $ go run $GOROOT/src/crypto/tls/generate_cert.go -host localhost Example output: ==> cache-1.router: Error: Not a valid RSA key: Neither PUB key nor PRIV key:: nested asn1 error at /var/govuk/puppet/modules/nginx/manifests/config/ssl.pp:30 on node cache-1.router.dev.gov.uk
2015-11-20Merge pull request #548 from bmjen/ruby187Hunter Haugen
Fix Gemfile to work with ruby 1.8.7
2015-11-20Fix Gemfile to work with ruby 1.8.7Bryan Jen
2015-11-20Merge pull request #543 from ghoneycutt/patch-2Bryan Jen
Use absolute class name in example
2015-11-20Merge pull request #547 from reidmv/fm_3773Bryan Jen
(FM-3773) Fix root_home fact on AIX 5.x
2015-11-19(FM-3773) Fix root_home fact on AIX 5.xReid Vandewiele
The -C (capital C) flag to lsuser is incorrect. It should be -c (lowercase). this commit updates the aix root_home fact to use `lsuser -c`, rather than `lsuser -C`.
2015-11-09Merge pull request #544 from HelenCampbell/readmeadditionDavid Schmitt
pick_default addition to readme
2015-11-09pick_default addition to readmeHelen Campbell
2015-11-06Use absolute class name in exampleGarrett Honeycutt
2015-11-06Merge pull request #542 from greg0ire/patch-1Helen
use properly encoded characters
2015-11-03use properly encoded charactersGrégoire Paris
This is more severe than it sounds. These characters make puppet fail with the following message : > Error 400 on SERVER: "\xC3" on US-ASCII
2015-10-28Merge pull request #541 from mattflaschen/patch-1David Schmitt
Fix capitalize docs
2015-10-27Fix capitalize docsMatt Flaschen
Capitalize lower-cases the remaining characters (due to the Ruby function having this behavior); document this, and make minor wording tweaks.
2015-10-23Merge pull request #540 from marrero984/update_str2bool_readmeDavid Schmitt
(#2183) updated str2bool readme wording
2015-10-22(#2183) updated str2bool readme wordingmarrero984
2015-10-16Merge pull request #538 from mmckinst/bool2str_enhanceDavid Schmitt
add functionality to bool2str function
2015-10-15add functionality to bool2str to return strings of your choice for a booleanMark McKinstry
2015-10-15Merge pull request #539 from mentat/MODULES-2696Hunter Haugen
Add check to ensure regex does not throw for none type.
2015-10-15Add check to ensure regex does not throw for none type.Jesse Lovelace
Add a quick check to ensure puppetversion value is not nil and supporting test.
2015-10-15Merge pull request #537 from cmurphy/fix_load_module_metadataDavid Schmitt
Fix load module metadata
2015-10-14Let load_module_metadata succeed on empty fileColleen Murphy
Some modules or module versions don't have a metadata.json file, but we might still want to use the load_module_metadata function on them. The lack of a file can still give us important information. For example, it might tell us that the version of the module installed is "very old" even if we can't read the version number directly. This patch adds a parameter to let the user specify if an empty file is acceptable. To preserve backwards compatibility it does not change the current default behavior, which is to raise an error if metadata.json does not exist.
2015-10-14Rename load_module_metadata test pathColleen Murphy
`rake spec` only finds test files that end in _spec.rb, so this test was not being run. Correct the path name so that the test runs properly.
2015-10-14Merge pull request #536 from DavidS/improve-file_line-docsTP Honey
(MODULES-2421) improve description of file_line
2015-10-13(MODULES-2421) improve description of file_lineDavid Schmitt
This mostly needed extraction of the existing doc strings from the type.
2015-10-13Merge pull request #535 from martinpfeifer/package_provider_factDavid Schmitt
prevent deprecation warning about the allow_virtual parameter
2015-10-13prevent deprecation warning about the allow_virtual parameterMartin Pfeifer
2015-10-01Merge pull request #534 from asasfu/feature/package_provider_factBryan Jen
Add package_provider fact
2015-09-28Merge pull request #533 from HelenCampbell/MODULES-2614-ImprovedDavid Schmitt
Modules 2614 improved numeric value handling on empty function
2015-09-28Added acceptance test and updated readmeHelen Campbell
2015-09-28Check for numeric values as empty fails on thoseRoman Mueller
2015-09-28Merge pull request #532 from DavidS/fix-is_a-readmeHelen
(FM-3701) Update README for is_a
2015-09-28(FM-3701) Update README for is_aDavid Schmitt
2015-09-28Merge pull request #531 from asasfu/improvement/service_provider_factDavid Schmitt
fixup-PR#506 Speed improvements in facter resolution
2015-09-25fixup-PR#506 Speed improvements in facter resolutionAdam S
This is to improve speed on Facter resolution of service_provider fact that was just introduced in PR# 506. The improvements go from 280ms resolution time approx. down to 2ms resolution time approx. by adding requires statements.
2015-09-25Add package_provider factAdam S
This adds a package_provider fact for situations where we need to be able to know the client's package provider in a simple way. Situations such as: package { 'name': install_options => [] } As those tend to be package provider specific options.
2015-09-24Merge pull request #506 from binford2k/feature/service_provider_factHunter Haugen
Add a service_provider fact
2015-09-23Merge pull request #530 from HelenCampbell/MODULES-2614David Schmitt
Adding update to empty function readme
2015-09-23Adding update to empty function readmeHelen Campbell
2015-09-21Merge pull request #528 from mhaskel/is_a_fixesBryan Jen
Update is_a acceptance tests to only run on puppet4
2015-09-21Update is_a acceptance tests to only run on puppet4Morgan Haskel
2015-09-21Merge pull request #527 from mhaskel/511_compatibilityBryan Jen
Fix backwards compatibility from #511
2015-09-21Fix backwards compatibility from #511Morgan Haskel
Maintain the old behavior in the case where the optional second parameter isn't passed. Also, adding arity is backwards incompatible since stdlib still supports 2.7, so remove that.
2015-09-17Merge pull request #526 from DavidS/improve-validate_re-docsHunter Haugen
(MAINT) validate_re: Clarify docs and error message
2015-09-17(MAINT) validate_re: Clarify docs and error messageDavid Schmitt
2015-09-14Merge pull request #524 from binford2k/docs/intersection_truthinessDavid Schmitt
Clarify what an empty intersection looks like.
2015-09-14Clarify what an empty intersection looks like.Ben Ford
2015-09-14Merge pull request #523 from DavidS/modules-2516-is_aBryan Jen
(MODULES-2561) add is_a function
2015-09-14Merge pull request #511 from dmitryilyin/parseyaml_defaultBryan Jen
[MODULES-2462] Improve parseyaml function
2015-09-14(MODULES-2516) Adds an is_a() functionDavid Schmitt
The data type system is very hard to understand. Many people don't understand why type_of([1,2,3]) == Array will fail, but type_of([1,2,3]) <= Array passes. This does a simpler validation that doesn't rely on explicit data types. Instead, use $foo = [1,2,3] if $foo.is_a(Array) { notify { 'This is an array': } } This is based on code by Ben Ford <ben.ford@puppetlabs.com>. * Added acceptance tests * Added dispatch * Improved unit tests * Added docs to README