Age | Commit message (Collapse) | Author |
|
|
|
Fix time() on 1.8.7
|
|
The time() function takes an argument of a timezone, and always returns
time in epoch format. The epoch format is the number of seconds that
have elapsed since January 1, 1970 (midnight UTC/GMT), not counting leap
seconds. This means that it is universally the same regardless of
timezones.
I don't know what the timezone argument is supposed to do, and it is not
documented. So lets just make 1.8.7 work like > 1.8.7
|
|
Fix spelling of camelcase
|
|
Improve fqdn_rotate/fqdn_rand_string acceptance tests
|
|
|
|
|
|
|
|
Gemfile: specify minimum rspec-puppet version
|
|
Only 2.2 contains all the features we're currently using. Documenting
that in the Gemfile should make that clear.
|
|
fqdn_rotate: Don't use the value itself as part of the random seed
|
|
|
|
|
|
Previously, the random number generator was seeded with the array or
string to be rotated in addition to any values specifically provided for
seeding. This behavior is potentially insecure in that it allows an
attacker who can modify the source data to choose the post-shuffle
order.
|
|
(MODULES-1882) convert function tests to rspec-puppet
|
|
This is copied and changed code from an older version of puppet's internal
test setup code. It does not work with puppet4.
|
|
Tests in the new style produces the following documentation output:
abs
should not eq nil
should run abs() and raise an Puppet::ParseError
should run abs(-34) and return 34
should run abs("-34") and return 34
should run abs(34) and return 34
should run abs("34") and return 34
|
|
Usage:
describe 'puppet3 behaviour', :unless => RSpec.configuration.puppet_future do
describe 'puppet4 behaviour', :if => RSpec.configuration.puppet_future do
|
|
environmentpath
|
|
|
|
The :validate task is already provided by
puppetlabs_spec_helper/rake_tasks and would check files twice.
The metadata.json linting is just good form.
|
|
|
|
|
|
simplify mac address regex
|
|
let the computer do the counting and repetition and case
|
|
(MODULES-2071) Patch file_line provider to use multiple with after
|
|
parameter multiple in function handle_create_with_after
Without this, file_line resource without the `match` parameter but with the `after` param will throw an error if there are multiple matches for the after expression. This patch creates the handling for the `multiple` parameter in handle_create_with_after. This allows you to add a line after the `after` expression if it appears at multiple points in a file.
Updated reference to `file_line` in the README to reflect that the multiple parameter can be set when using `after` and/or `match` as the matching regex.
|
|
validate_integer, validate_numeric: explicitely reject hashes in arrays
|
|
Without this patch, Ruby 1.8's Hash#to_s behaviour causes [{1=>2}] to be
treated as "12" when validating values.
|
|
|
|
fqdn_rotate: reset srand seed correctly on old ruby versions
|
|
Without this, the global seed is reseeded on every use
of fqdn_rotate, which is a waste. Older rubies might even use a
time-base seed which adversly impacts the quality of the RNG.
|
|
(FM-2130) Document new location of facts.d cache
|
|
Remove all the pops stuff
|
|
Update CHANGELOG.md
|
|
|
|
DOC-1504: Readme edits
|
|
|
|
The rspec-puppet matchers don't allow to check the return types, but
this is a pretty rare thing to need to do anyway, so probably not worth
patching rspec-puppet
|
|
|
|
sync via modulesync
|
|
|
|
range(): fix TypeError(can't convert nil into Integer) when using range ...
|
|
|
|
Restore removed functionality to range()
|
|
Fix pw_hash() on JRuby < 1.7.17
|
|
|
|
This reverts commit 063c58a992c1b5441b7e7b2a2e4886531035bb25, which
actually removed non-dead code. Specifically, it removed the ability to
make calls such as `range('2..3')`, `range('2...3')`, and
`range('2-3')`.
cf. https://github.com/puppetlabs/puppetlabs-stdlib/pull/443#commitcomment-11055565
|
|
The previous change to this function broke it on JRuby before 1.7.17 by
attempting to use a variable that wasn't defined (`salt`). To fix this,
define `salt` ahead of time and use that instead of building the salt
later.
cf. https://github.com/puppetlabs/puppetlabs-stdlib/pull/443#discussion_r29718588
|
|
Prep work for new specs
|