Age | Commit message (Collapse) | Author |
|
* 2.3.x:
fix regression in #11017 properly
|
|
fix regression in #11017 properly
|
|
We need the defaultvalues for that.
|
|
* 2.3.x:
Fix spec tests using the new spec_helper
|
|
* 2.2.x:
Fix spec tests using the new spec_helper
|
|
This patch back ports the file from the master branch. The spec tests
fail without this patch applied. This should make it easier to setup
Puppet settings using the puppet_spec_helper project.
|
|
* 2.3.x:
Update CHANGELOG for 2.3.2 release
Make file_line default to ensure => present
Memoize file_line spec instance variables
Fix spec tests using the new spec_helper
|
|
|
|
* fix/2.3.x/file_line_ensure:
Make file_line default to ensure => present
Memoize file_line spec instance variables
Fix spec tests using the new spec_helper
|
|
The examples in the file_line resource documentation state the following
resource should work:
file_line { 'sudo_rule':
path => '/etc/sudoers',
line => '%sudo ALL=(ALL) ALL',
}
Without this patch the example does not work because ensure is not set
to present.
This patch fixes the problem by setting the default value of ensure to
present.
|
|
This just changes the instance variables to a memoized let block and
gets ride of the before :each block.
The patch has no change in behavior.
|
|
This patch back ports the file from the master branch. The spec tests
fail without this patch applied. This should make it easier to setup
Puppet settings using the puppet_spec_helper project.
|
|
* 2.3.x:
Revert "Merge remote-tracking branch 'eshamow/tickets/bug/13595_restrict_initialize_everything_for_tests' into 2.2.x"
(#13595) initialize_everything_for_tests couples modules Puppet ver
|
|
* 2.2.x:
Revert "Merge remote-tracking branch 'eshamow/tickets/bug/13595_restrict_initialize_everything_for_tests' into 2.2.x"
(#13595) initialize_everything_for_tests couples modules Puppet ver
|
|
cprice-puppet/ticket/master/13693-use-puppetlabs-spec-helper
(#13693) moving logic from local spec_helper to puppetlabs_spec_helper
|
|
This should simplify future compatibility between various versions
of stdlib and various versions of puppet core.
|
|
'eshamow/tickets/bug/13595_restrict_initialize_everything_for_tests' into 2.2.x"
This reverts commit 40da421c0480f940638d0db9aabf180500d6ae5c, reversing
changes made to 69465b0f3e0c0c5284812bfa76ab8d3c254d10a9.
|
|
'eshamow/tickets/bug/13595_restrict_initialize_everything_for_tests' into 2.2.x
* eshamow/tickets/bug/13595_restrict_initialize_everything_for_tests:
(#13595) initialize_everything_for_tests couples modules Puppet ver
|
|
Replace regex used in spec_helper.rb to disallow both Puppet 2.6 and any
2.7 prior to 13.
|
|
* 2.4.x:
(#13439) Fix MRI 1.9 issue with spec_helper
|
|
* 2.3.x:
(#13439) Fix MRI 1.9 issue with spec_helper
|
|
* 2.2.x:
(#13439) Fix MRI 1.9 issue with spec_helper
|
|
* ticket/2.2.x/13439_fix_spec_helper_try3:
(#13439) Fix MRI 1.9 issue with spec_helper
|
|
When using MRI 1.9.x the stdlib spec helper does not invoke because
Puppet.settings.private_methods returns symbols instead of strings.
This is a problem because we need to set default configuration settings
like Puppet[:vardir] when using the compiler.
This patch fixes the issue by simply checking the Puppet version. This
seems a better choice than rescuing NoMethodError since the method might
be renamed or removed in the future.
|
|
* 2.4.x:
(#13439) Fix test failures with Puppet 2.6.x
(#13439) refactor spec helper for compatibility with both puppet 2.7 and master
|
|
* 2.3.x:
(#13439) Fix test failures with Puppet 2.6.x
(#13439) refactor spec helper for compatibility with both puppet 2.7 and master
|
|
* 2.2.x:
(#13439) Fix test failures with Puppet 2.6.x
|
|
* ticket/2.2.x/13439_fix_spec_helper_try2:
(#13439) Fix test failures with Puppet 2.6.x
|
|
Without this patch the spec_helper sends a message named
initialize_everything_for_tests to Puppet.settings. This is a problem
because Puppet 2.6.x does not have this method, only Puppet 2.7.x and
Puppet master have this method at this time and we're getting false
positive test failures.
This patch fixes the problem by looking before we leap. We test if the
private method exists before calling it. This works with Ruby 1.8.5 and
onwards and Puppet 2.6, 2.7 and master.
This should fix all of the failures I've caused in Jenkins today.
|
|
* 2.2.x:
(#13439) refactor spec helper for compatibility with both puppet 2.7 and master
|
|
* ticket/2.2.x/13439_fix_spec_helper:
(#13439) refactor spec helper for compatibility with both puppet 2.7 and master
|
|
master
|
|
(#13205) Rotate array/string randomley based on fqdn, fqdn_rotate()
|
|
* 2.3.x:
(#13494) Specify the behavior of zero padded strings
Update CHANGELOG, Modulefile for 2.1.3
|
|
* 2.2.x:
(#13494) Specify the behavior of zero padded strings
Update CHANGELOG, Modulefile for 2.1.3
Conflicts:
CHANGELOG
Modulefile
|
|
* 2.1.x:
Update CHANGELOG, Modulefile for 2.1.3
Conflicts:
CHANGELOG
Modulefile
|
|
* maint/2.2.x/range_spec_tests:
(#13494) Specify the behavior of zero padded strings
|
|
Without this patch the specified behavior of strings that are numeric
only and zero padded is unclear and untested in the spec tests. This is
a problem because it's not clear that range('00', '10') will actually
return [ "0", "1", ..., "10" ] instead of [ "00", "01", ..., "10" ]
This patch addresses the issue by providing explicit test coverage. If
the string conversion behavior of puppet changes, this test will begin
to fail.
|
|
|
|
|
|
* 2.3.x:
Update CHANGELOG and Modulefile for 2.3.1
(#13091) Fix LoadError exception with puppet apply
|
|
|
|
jeffmccune/ticket/2.3.x/13091_stdlib_throws_a_loaderror_when_running_with_puppet_apply
(#13091) Fix LoadError exception with puppet apply
|
|
Puppet apply does not add the stdlib lib directory to the $LOAD_PATH.
This is a problem because the puppet_vardir fact requires the
puppet_settings library to be available for the `with_puppet` utility
method.
Without this patch, puppet apply will result in the following error:
$ puppet apply --modulepath=/vagrant/modules -e 'notice $puppet_vardir'
warning: Could not load fact file stdlib/lib/facter/puppet_vardir.rb: no such file to load -- facter/util/puppet_settings
notice: Scope(Class[main]):
notice: Finished catalog run in 0.01 seconds
With this patch applied, puppet apply works as expected:
$ puppet apply --modulepath=/vagrant/modules.pe -e 'notice $puppet_vardir'
notice: Scope(Class[main]): /Users/jeff/.puppet/var
notice: Finished catalog run in 0.01 seconds
This patch defensively tries to load facter/util/puppet_settings. If it cannot
load it, it falls back to trying to explicitly locate and load the library.
Once puppet is fixed such that a modules lib directory is truly in the
$LOAD_PATH, the fall back implementation will no longer be exercised since the
LoadError should not be raised.
|
|
* 2.3.x:
Update CHANGELOG, Modulefile for 2.3.0 release
|
|
|
|
* 2.3.x:
(#12357) Fix broken compatibility with Puppet 2.6
(maint) Comment Ken's fix to String#any?
(#13018) Fix missing method any? message for ruby 1.9.x
(#12357) Add ability to display an error message from validate_re
(#12357) Add validate_absolute_path() function
(maint) Stop printing the directory of spec_helper
(#12357) Make facter_dot_d look in Puppet[:confdir]/facts.d
(#12357) Add puppet_vardir custom fact
(#12357) Fix root_home fact on Windows
|
|
jeffmccune/bug/2.3.x/fix_absolute_path_error_with_puppet26
(#12357) Fix broken compatibility with Puppet 2.6
|
|
Without this patch, the previous change set to the
validate_absolute_path() parser function contains Puppet 2.6
incompatible changes. stdlib 2.x is compatible with Puppet 2.6. These
changes are a problem because we cannot introduce backwards incompatible
changes in a minor release.
This patch fixes the problem by back porting the implementation of the
`Puppet::Util.absolute_path?` from 2.7.x to the function block itself.
The function block tests to see if `Puppet::Util.absolute_path?` will
respond and if not, falls back to the inline back ported implementation.
The spec tests have been updated to simulate the behavior of Puppet 2.6
even when running with Puppet 2.7.
|
|
* ticket/2.3.x/13018_any_on_string:
(maint) Comment Ken's fix to String#any?
(#13018) Fix missing method any? message for ruby 1.9.x
|