From 38c8da441d457a9c3820845d13f70a8d612f8cf4 Mon Sep 17 00:00:00 2001 From: Michael Hashizume Date: Tue, 3 Oct 2023 08:38:29 -0700 Subject: (maint) Update commit check This commit updates the commits Rake check to include commit summaries that begin with the Puppet Agent (PA) Jira project and removes references to a non-existent CONTRIBUTING.md. --- rakelib/commits.rake | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/rakelib/commits.rake b/rakelib/commits.rake index 42eb209..7cee9fa 100644 --- a/rakelib/commits.rake +++ b/rakelib/commits.rake @@ -1,4 +1,4 @@ -desc "verify that commit messages match CONTRIBUTING.md requirements" +desc "verify that commit summaries are properly formatted" task(:commits) do # This rake task looks at the summary from every commit from this branch not # in the branch targeted for a PR. @@ -7,11 +7,10 @@ task(:commits) do %x{git log --no-merges --pretty=%s #{commit_range}}.each_line do |commit_summary| # This regex tests for the currently supported commit summary tokens. # The exception tries to explain it in more full. - if /^Release prep|\((maint|packaging|doc|docs|modules-\d+)\)|revert/i.match(commit_summary).nil? - raise "\n\n\n\tThis commit summary didn't match CONTRIBUTING.md guidelines:\n" \ - "\n\t\t#{commit_summary}\n" \ - "\tThe commit summary (i.e. the first line of the commit message) should start with one of:\n" \ - "\t\t(MODULES-) # this is most common and should be a ticket at tickets.puppet.com\n" \ + if /^Release prep|\((maint|packaging|doc|docs|modules|pa-\d+)\)|revert/i.match(commit_summary).nil? + raise "\n\n\n\tPlease make sure that your commit summary (i.e. the first line of the commit message) starts with one of the following:\n" \ + "\t\t(PA-)\n" \ + "\t\t(MODULES-)\n" \ "\t\t(docs)\n" \ "\t\t(docs)(DOCUMENT-)\n" \ "\t\t(packaging)\n" -- cgit v1.2.3 From 7525e013f7421d4a1c5649b91f0d5251b761a95e Mon Sep 17 00:00:00 2001 From: Michael Hashizume Date: Tue, 3 Oct 2023 08:38:53 -0700 Subject: (PA-5804) Update Checkout GitHub Action The Checkout GitHub Action v3 uses Node 16, which hit end-of-life on September 11, 2023. This commit updates all instances of the Checkout Action from v3 to v4. --- .github/workflows/auto_release.yml | 2 +- .github/workflows/release.yml | 4 ++-- .github/workflows/static_code_analysis.yaml | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/auto_release.yml b/.github/workflows/auto_release.yml index 3799f04..5586fd4 100644 --- a/.github/workflows/auto_release.yml +++ b/.github/workflows/auto_release.yml @@ -28,7 +28,7 @@ jobs: echo STEP_START=$(date +%s) >> $GITHUB_ENV - name: "Checkout Source" if: ${{ github.repository_owner == 'puppetlabs' }} - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 0 persist-credentials: false diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index d9604ad..0240b29 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -9,7 +9,7 @@ jobs: runs-on: ubuntu-20.04 steps: - name: Checkout code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: ref: ${{ github.ref }} clean: true @@ -33,7 +33,7 @@ jobs: runs-on: ubuntu-20.04 steps: - name: Checkout code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: ref: ${{ github.ref }} clean: true diff --git a/.github/workflows/static_code_analysis.yaml b/.github/workflows/static_code_analysis.yaml index b639220..575cde7 100644 --- a/.github/workflows/static_code_analysis.yaml +++ b/.github/workflows/static_code_analysis.yaml @@ -18,7 +18,7 @@ jobs: runs-on: 'ubuntu-20.04' steps: - name: Checkout current PR code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 0 -- cgit v1.2.3