From f815ee478ef89830d45dfcdd3b8f8f66f768a4a0 Mon Sep 17 00:00:00 2001 From: Adam Jahn Date: Fri, 8 Jul 2016 15:41:26 -0400 Subject: make contexts less wordy --- spec/defines/samba__server__share_spec.rb | 98 +++++++++++++++---------------- 1 file changed, 49 insertions(+), 49 deletions(-) diff --git a/spec/defines/samba__server__share_spec.rb b/spec/defines/samba__server__share_spec.rb index a621a15..2d779c3 100644 --- a/spec/defines/samba__server__share_spec.rb +++ b/spec/defines/samba__server__share_spec.rb @@ -77,7 +77,7 @@ describe 'samba::server::share', :type => :define do } ], }).each do |os, facts| - context "When on an #{os} system" do + context "for #{os}" do let(:facts) do facts.merge({ :concat_basedir => '/tmp', @@ -85,7 +85,7 @@ describe 'samba::server::share', :type => :define do }) end - context 'when called with base options' do + context 'with base options' do let(:title) { 'test_share' } let(:params) {{ :ensure => 'present' @@ -109,7 +109,7 @@ describe 'samba::server::share', :type => :define do } end#no params - context 'when called with ensure set to absent' do + context 'with ensure set to absent' do let(:title) { 'test_share' } let(:params) {{ :ensure => 'absent' @@ -125,7 +125,7 @@ describe 'samba::server::share', :type => :define do } end#no params - context 'when called with available set to true' do + context 'with available set to true' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -134,7 +134,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("available", "yes") } end#available true - context 'when called with available set to false' do + context 'with available set to false' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -143,7 +143,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("available", "no") } end#available false - context 'when called with browsable set to true' do + context 'with browsable set to true' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -152,7 +152,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("browsable", "yes") } end#browsable false - context 'when called with browsable set to false' do + context 'with browsable set to false' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -161,7 +161,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("browsable", "no") } end#browsable false - context 'when called with root_preexec set to /bin/true' do + context 'with root_preexec set to /bin/true' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -170,7 +170,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("root preexec", "'/bin/true'") } end#root_preexec - context 'when called with comment set to "testing testing"' do + context 'with comment set to "testing testing"' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -179,7 +179,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("comment", "'testing testing'") } end#comment - context 'when called with copy set to "testing testing"' do + context 'with copy set to "testing testing"' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -188,7 +188,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("copy", "'testing testing'") } end#copy - context 'when called with create_mask set to "755"' do + context 'with create_mask set to "755"' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -197,7 +197,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("create mask", "'755'") } end#create mask - context 'when called with directory_mask set to "755"' do + context 'with directory_mask set to "755"' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -206,7 +206,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("directory mask", "'755'") } end#directory_mask - context 'when called with force_create_mask set to "755"' do + context 'with force_create_mask set to "755"' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -215,7 +215,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("force create mask", "'755'") } end#force_create_mask - context 'when called with force_directory_mode set to "755"' do + context 'with force_directory_mode set to "755"' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -224,7 +224,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("force directory mode", "'755'") } end#force_directory_mode - context 'when called with force_group set to "nogroup"' do + context 'with force_group set to "nogroup"' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -233,7 +233,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("force group", "'nogroup'") } end#force_group - context 'when called with force_user set to "nobody"' do + context 'with force_user set to "nobody"' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -242,7 +242,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("force user", "'nobody'") } end#force_user - context 'when called with guest_ok set to true' do + context 'with guest_ok set to true' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -251,7 +251,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("guest ok", "yes") } end#guest_ok true - context 'when called with guest_ok set to false' do + context 'with guest_ok set to false' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -260,7 +260,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("guest ok", "no") } end#guest_ok false - context 'when called with guest_only set to true' do + context 'with guest_only set to true' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -269,7 +269,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("guest only", "yes") } end#guest_only false - context 'when called with guest_only set to false' do + context 'with guest_only set to false' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -278,7 +278,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("guest only", "no") } end#guest_only false - context 'when called with hide_unreadable set to true' do + context 'with hide_unreadable set to true' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -287,7 +287,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("hide unreadable", "yes") } end#hide_unreadable true - context 'when called with hide_unreadable set to false' do + context 'with hide_unreadable set to false' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -296,7 +296,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("hide unreadable", "no") } end#hide_unreadable false - context 'when called with path set to /tmp' do + context 'with path set to /tmp' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -305,7 +305,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("path", "'/tmp'", nil) } end#path - context 'when called with read_only set to true' do + context 'with read_only set to true' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -314,7 +314,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("read only", "yes") } end#read_only true - context 'when called with read_only set to false' do + context 'with read_only set to false' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -323,7 +323,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("read only", "no") } end#read_only false - context 'when called with public set to true' do + context 'with public set to true' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -332,7 +332,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("public", "yes") } end#public true - context 'when called with public set to false' do + context 'with public set to false' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -341,7 +341,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("public", "no") } end#public false - context 'when called with writable set to true' do + context 'with writable set to true' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -350,7 +350,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("writable", "yes") } end#writable true - context 'when called with writable set to false' do + context 'with writable set to false' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -359,7 +359,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("writable", "no") } end#writable false - context 'when called with printable set to true' do + context 'with printable set to true' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -368,7 +368,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("printable", "yes") } end#printable true - context 'when called with printable set to false' do + context 'with printable set to false' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -377,7 +377,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("printable", "no") } end#printable false - context 'when called with follow_symlinks set to true' do + context 'with follow_symlinks set to true' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -386,7 +386,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("follow symlinks", "yes") } end#follow_symlinks true - context 'when called with follow_symlinks set to false' do + context 'with follow_symlinks set to false' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -395,7 +395,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("follow symlinks", "no") } end#follow_symlinks false - context 'when called with wide_links set to true' do + context 'with wide_links set to true' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -404,7 +404,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("wide links", "yes") } end#wide_links true - context 'when called with wide_links set to false' do + context 'with wide_links set to false' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -413,7 +413,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("wide links", "no") } end#wide_links false - context 'when called with map_acl_inherit set to true' do + context 'with map_acl_inherit set to true' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -422,7 +422,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("map acl inherit", "yes") } end#map_acl_inherit true - context 'when called with map_acl_inherit set to false' do + context 'with map_acl_inherit set to false' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -431,7 +431,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("map acl inherit", "no") } end#map_acl_inherit false - context 'when called with store_dos_attributes set to true' do + context 'with store_dos_attributes set to true' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -440,7 +440,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("store dos attributes", "yes") } end#store_dos_attributes true - context 'when called with store_dos_attributes set to false' do + context 'with store_dos_attributes set to false' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -449,7 +449,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("store dos attributes", "no") } end#store_dos_attributes false - context 'when called with strict_allocate set to true' do + context 'with strict_allocate set to true' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -458,7 +458,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("strict allocate", "yes") } end#strict_allocate true - context 'when called with strict_allocate set to false' do + context 'with strict_allocate set to false' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -467,7 +467,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("strict allocate", "no") } end#strict_allocate false - context 'when called with valid_users set to "bill,ben"' do + context 'with valid_users set to "bill,ben"' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -476,7 +476,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("valid users", "'bill,ben'") } end#valid_users - context 'when called with op_locks set to "testing"' do + context 'with op_locks set to "testing"' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -485,7 +485,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("oplocks", "'testing'") } end#op_locks - context 'when called with level2_oplocks set to "testing"' do + context 'with level2_oplocks set to "testing"' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -494,7 +494,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("level2 oplocks", "'testing'") } end#level2_oplocks - context 'when called with veto_oplock_files set to "testing"' do + context 'with veto_oplock_files set to "testing"' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -503,7 +503,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("veto oplock files", "'testing'") } end#veto_oplock_files - context 'when called with write_list set to "bill,ben"' do + context 'with write_list set to "bill,ben"' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -512,7 +512,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("write list", "'bill,ben'") } end#write_list - context 'when called with hide_dot_files set to true' do + context 'with hide_dot_files set to true' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -521,7 +521,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("hide dot files", "yes") } end#hide_dot_files true - context 'when called with hide_dot_files set to false' do + context 'with hide_dot_files set to false' do include_examples "default share" let(:params) {{ :ensure => 'present', @@ -530,7 +530,7 @@ describe 'samba::server::share', :type => :define do let(:change_set) { default_changes.with("hide dot files", "no") } end#hide_dot_files false - context 'when called with root_preexec set to "/bin/test"' do + context 'with root_preexec set to "/bin/test"' do include_examples "default share" let(:params) {{ :ensure => 'present', -- cgit v1.2.3