From 87232b5f0aef4d25e1438dc11000d7c1be205842 Mon Sep 17 00:00:00 2001 From: root Date: Sat, 5 Mar 2016 21:56:29 +0100 Subject: Add option hide dot files to share. --- manifests/server/share.pp | 6 ++++++ 1 file changed, 6 insertions(+) mode change 100644 => 100755 manifests/server/share.pp diff --git a/manifests/server/share.pp b/manifests/server/share.pp old mode 100644 new mode 100755 index 7f8191c..b0690bb --- a/manifests/server/share.pp +++ b/manifests/server/share.pp @@ -29,6 +29,7 @@ define samba::server::share($ensure = present, $map_acl_inherit = '', $store_dos_attributes = '', $strict_allocate = '', + $hide_dot_files = '', ) { $incl = $samba::server::incl @@ -177,6 +178,11 @@ define samba::server::share($ensure = present, '' => "rm \"${target}/write list\"", default => "set \"${target}/write list\" '${write_list}'", }, + $hide_dot_files ? { + true => "set \"${target}/hide dot files\" yes", + false => "set \"${target}/hide dot files\" no", + default => "rm \"${target}/hide dot files\"", + }, ] augeas { "${name}-changes": -- cgit v1.2.3 From e8d067895daebc19a3c39bd3071922bec1a34327 Mon Sep 17 00:00:00 2001 From: Hielke Jager Date: Wed, 9 Mar 2016 19:32:46 +0100 Subject: [TASK] Change spec to check for hide_dot_files in share. --- spec/acceptance/basic_samba_spec.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/spec/acceptance/basic_samba_spec.rb b/spec/acceptance/basic_samba_spec.rb index 76e7f9f..b4cc0e8 100644 --- a/spec/acceptance/basic_samba_spec.rb +++ b/spec/acceptance/basic_samba_spec.rb @@ -21,6 +21,7 @@ describe 'basic samba' do force_directory_mode => 0777, force_group => 'group', force_user => 'user', + hide_dot_files => false } "} -- cgit v1.2.3 From 1ce0857037cc6187e4fa66b941bde8245bbb947b Mon Sep 17 00:00:00 2001 From: Hielke Jager Date: Wed, 9 Mar 2016 19:35:59 +0100 Subject: And add the last , --- spec/acceptance/basic_samba_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/acceptance/basic_samba_spec.rb b/spec/acceptance/basic_samba_spec.rb index b4cc0e8..8a9e363 100644 --- a/spec/acceptance/basic_samba_spec.rb +++ b/spec/acceptance/basic_samba_spec.rb @@ -21,7 +21,7 @@ describe 'basic samba' do force_directory_mode => 0777, force_group => 'group', force_user => 'user', - hide_dot_files => false + hide_dot_files => false, } "} -- cgit v1.2.3 From ca2e283c1fdc916f5d7f9fb99244bc9d53c766b6 Mon Sep 17 00:00:00 2001 From: Hielke Jager Date: Wed, 9 Mar 2016 23:25:46 +0100 Subject: Select older version of rake for the test. The newest version is missing the last_comment method. --- Gemfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) mode change 100644 => 100755 Gemfile diff --git a/Gemfile b/Gemfile old mode 100644 new mode 100755 index 27d092a..a89c9e6 --- a/Gemfile +++ b/Gemfile @@ -11,7 +11,7 @@ group :development do end group :test do - gem "rake" + gem "rake", '< 11.0' gem "puppet", ENV['PUPPET_VERSION'] || '~> 3.7.0' gem "puppet-lint", :github => 'rodjek/puppet-lint', :ref => '2546fed6be894bbcff15c3f48d4b6f6bc15d94d1' -- cgit v1.2.3