aboutsummaryrefslogtreecommitdiff
path: root/Rakefile
diff options
context:
space:
mode:
authorLuchian Nemes <luchian.nemes@puppet.com>2020-10-06 09:34:44 +0300
committerLuchian Nemes <luchian.nemes@puppet.com>2020-10-06 09:34:44 +0300
commitbc267049d94a892f5d1731568637b3729cd970eb (patch)
tree1e30720c8b61728b5c2cf945fdce3112779f47ea /Rakefile
parentb9ae26104f23ea22b19ef159cd6b72f0d615417d (diff)
downloadpuppet-hosts_core-bc267049d94a892f5d1731568637b3729cd970eb.tar.gz
puppet-hosts_core-bc267049d94a892f5d1731568637b3729cd970eb.tar.bz2
(maint) Add commit summary check
This commit adds the `commits` rake task and runs it in the Static Code Analysis workflow as a step.
Diffstat (limited to 'Rakefile')
-rw-r--r--Rakefile25
1 files changed, 25 insertions, 0 deletions
diff --git a/Rakefile b/Rakefile
index e1d5f7b..7f91a3f 100644
--- a/Rakefile
+++ b/Rakefile
@@ -84,3 +84,28 @@ EOM
end
end
+desc "verify that commit messages match CONTRIBUTING.md requirements"
+task(:commits) do
+ # This rake task looks at the summary from every commit from this branch not
+ # in the branch targeted for a PR.
+ commit_range = 'HEAD^..HEAD'
+ puts "Checking commits #{commit_range}"
+ %x{git log --no-merges --pretty=%s #{commit_range}}.each_line do |commit_summary|
+ # This regex tests for the currently supported commit summary tokens.
+ # The exception tries to explain it in more full.
+ if /^\((maint|packaging|doc|docs|modules-\d+)\)|revert/i.match(commit_summary).nil?
+ raise "\n\n\n\tThis commit summary didn't match CONTRIBUTING.md guidelines:\n" \
+ "\n\t\t#{commit_summary}\n" \
+ "\tThe commit summary (i.e. the first line of the commit message) should start with one of:\n" \
+ "\t\t(MODULES-<digits>) # this is most common and should be a ticket at tickets.puppet.com\n" \
+ "\t\t(docs)\n" \
+ "\t\t(docs)(DOCUMENT-<digits>)\n" \
+ "\t\t(packaging)\n"
+ "\t\t(maint)\n" \
+ "\n\tThis test for the commit summary is case-insensitive.\n\n\n"
+ else
+ puts "#{commit_summary}"
+ end
+ puts "...passed"
+ end
+end