1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
|
require 'spec_helper'
describe Puppet::Type.type(:cron).provider(:crontab) do
let :provider do
described_class.new(command: '/bin/true')
end
let :resource do
Puppet::Type.type(:cron).new(
minute: ['0', '15', '30', '45'],
hour: ['8-18', '20-22'],
monthday: ['31'],
month: ['12'],
weekday: ['7'],
name: 'basic',
command: '/bin/true',
target: 'root',
provider: provider,
)
end
let :resource_special do
Puppet::Type.type(:cron).new(
special: 'reboot',
name: 'special',
command: '/bin/true',
target: 'nobody',
)
end
let :resource_sparse do
Puppet::Type.type(:cron).new(
minute: ['42'],
target: 'root',
name: 'sparse',
)
end
let :record_special do
{
record_type: :crontab,
special: 'reboot',
command: '/bin/true',
on_disk: true,
target: 'nobody',
}
end
let :record do
{
record_type: :crontab,
minute: ['0', '15', '30', '45'],
hour: ['8-18', '20-22'],
monthday: ['31'],
month: ['12'],
weekday: ['7'],
special: :absent,
command: '/bin/true',
on_disk: true,
target: 'root',
}
end
describe 'when determining the correct filetype' do
it 'uses the suntab filetype on Solaris' do
Facter.stubs(:value).with(:osfamily).returns 'Solaris'
expect(described_class.filetype).to eq(Puppet::Util::FileType::FileTypeSuntab)
end
it 'uses the aixtab filetype on AIX' do
Facter.stubs(:value).with(:osfamily).returns 'AIX'
expect(described_class.filetype).to eq(Puppet::Util::FileType::FileTypeAixtab)
end
it 'uses the crontab filetype on other platforms' do
Facter.stubs(:value).with(:osfamily).returns 'Not a real operating system family'
expect(described_class.filetype).to eq(Puppet::Util::FileType::FileTypeCrontab)
end
end
# I'd use ENV.expects(:[]).with('USER') but this does not work because
# ENV["USER"] is evaluated at load time.
describe 'when determining the default target' do
it "should use the current user #{ENV['USER']}", if: ENV['USER'] do
expect(described_class.default_target).to eq(ENV['USER'])
end
it 'fallbacks to root', unless: ENV['USER'] do
expect(described_class.default_target).to eq('root')
end
end
describe '.targets' do
let(:tabs) { [described_class.default_target] + ['foo', 'bar'] }
before(:each) do
File.expects(:readable?).returns true
File.stubs(:file?).returns true
File.stubs(:writable?).returns true
end
after(:each) do
File.unstub :readable?, :file?, :writable?
Dir.unstub :foreach
end
it 'adds all crontabs as targets' do
Dir.expects(:foreach).multiple_yields(*tabs)
expect(described_class.targets).to eq(tabs)
end
end
describe 'when parsing a record' do
it 'parses a comment' do
expect(described_class.parse_line('# This is a test')).to eq(record_type: :comment,
line: '# This is a test')
end
it 'gets the resource name of a PUPPET NAME comment' do
expect(described_class.parse_line('# Puppet Name: My Fancy Cronjob')).to eq(record_type: :comment,
name: 'My Fancy Cronjob',
line: '# Puppet Name: My Fancy Cronjob')
end
it 'ignores blank lines' do
expect(described_class.parse_line('')).to eq(record_type: :blank, line: '')
expect(described_class.parse_line(' ')).to eq(record_type: :blank, line: ' ')
expect(described_class.parse_line("\t")).to eq(record_type: :blank, line: "\t")
expect(described_class.parse_line(" \t ")).to eq(record_type: :blank, line: " \t ")
end
it 'extracts environment assignments' do
# man 5 crontab: MAILTO="" with no value can be used to surpress sending
# mails at all
expect(described_class.parse_line('MAILTO=""')).to eq(record_type: :environment, line: 'MAILTO=""')
expect(described_class.parse_line('FOO=BAR')).to eq(record_type: :environment, line: 'FOO=BAR')
expect(described_class.parse_line('FOO_BAR=BAR')).to eq(record_type: :environment, line: 'FOO_BAR=BAR')
expect(described_class.parse_line('SPACE = BAR')).to eq(record_type: :environment, line: 'SPACE = BAR')
end
it 'extracts a cron entry' do
expect(described_class.parse_line('* * * * * /bin/true')).to eq(record_type: :crontab,
hour: :absent,
minute: :absent,
month: :absent,
weekday: :absent,
monthday: :absent,
special: :absent,
command: '/bin/true')
expect(described_class.parse_line('0,15,30,45 8-18,20-22 31 12 7 /bin/true')).to eq(record_type: :crontab,
minute: ['0', '15', '30', '45'],
hour: ['8-18', '20-22'],
monthday: ['31'],
month: ['12'],
weekday: ['7'],
special: :absent,
command: '/bin/true')
# A percent sign will cause the rest of the string to be passed as
# standard input and will also act as a newline character. Not sure
# if puppet should convert % to a \n as the command property so the
# test covers the current behaviour: Do not do any conversions
expect(described_class.parse_line('0 22 * * 1-5 mail -s "It\'s 10pm" joe%Joe,%%Where are your kids?%')).to eq(record_type: :crontab,
minute: ['0'],
hour: ['22'],
monthday: :absent,
month: :absent,
weekday: ['1-5'],
special: :absent,
command: 'mail -s "It\'s 10pm" joe%Joe,%%Where are your kids?%')
end
describe 'it should support special strings' do
['reboot', 'yearly', 'anually', 'monthly', 'weekly', 'daily', 'midnight', 'hourly'].each do |special|
it "should support @#{special}" do
expect(described_class.parse_line("@#{special} /bin/true")).to eq(record_type: :crontab,
hour: :absent,
minute: :absent,
month: :absent,
weekday: :absent,
monthday: :absent,
special: special,
command: '/bin/true')
end
end
end
end
describe '.instances' do
before :each do
described_class.stubs(:default_target).returns 'foobar'
end
describe 'on linux' do
before(:each) do
Facter.stubs(:value).with(:osfamily).returns 'Linux'
Facter.stubs(:value).with(:operatingsystem)
end
it 'contains no resources for a user who has no crontab' do
# `crontab...` does only capture stdout here. On vixie-cron-4.1
# STDERR shows "no crontab for foobar" but stderr is ignored as
# well as the exitcode.
described_class.target_object('foobar').expects(:`).with('crontab -u foobar -l 2>/dev/null').returns ''
expect(described_class.instances.select do |resource|
resource.get('target') == 'foobar'
end).to be_empty
end
it 'contains no resources for a user who is absent' do
# `crontab...` does only capture stdout. On vixie-cron-4.1
# STDERR shows "crontab: user `foobar' unknown" but stderr is
# ignored as well as the exitcode
described_class.target_object('foobar').expects(:`).with('crontab -u foobar -l 2>/dev/null').returns ''
expect(described_class.instances.select do |resource|
resource.get('target') == 'foobar'
end).to be_empty
end
it 'is able to create records from not-managed records' do
described_class.stubs(:target_object).returns File.new(my_fixture('simple'))
parameters = described_class.instances.map do |p|
h = { name: p.get(:name) }
Puppet::Type.type(:cron).validproperties.each do |property|
h[property] = p.get(property)
end
h
end
expect(parameters[0][:name]).to match(%r{unmanaged:\$HOME/bin/daily.job_>>_\$HOME/tmp/out_2>&1-\d+})
expect(parameters[0][:minute]).to eq(['5'])
expect(parameters[0][:hour]).to eq(['0'])
expect(parameters[0][:weekday]).to eq(:absent)
expect(parameters[0][:month]).to eq(:absent)
expect(parameters[0][:monthday]).to eq(:absent)
expect(parameters[0][:special]).to eq(:absent)
expect(parameters[0][:command]).to match(%r{\$HOME/bin/daily.job >> \$HOME/tmp/out 2>&1})
expect(parameters[0][:ensure]).to eq(:present)
expect(parameters[0][:environment]).to eq(:absent)
expect(parameters[0][:user]).to eq(:absent)
expect(parameters[1][:name]).to match(%r{unmanaged:\$HOME/bin/monthly-\d+})
expect(parameters[1][:minute]).to eq(['15'])
expect(parameters[1][:hour]).to eq(['14'])
expect(parameters[1][:weekday]).to eq(:absent)
expect(parameters[1][:month]).to eq(:absent)
expect(parameters[1][:monthday]).to eq(['1'])
expect(parameters[1][:special]).to eq(:absent)
expect(parameters[1][:command]).to match(%r{\$HOME/bin/monthly})
expect(parameters[1][:ensure]).to eq(:present)
expect(parameters[1][:environment]).to eq(:absent)
expect(parameters[1][:user]).to eq(:absent)
expect(parameters[1][:target]).to eq('foobar')
end
it 'is able to parse puppet managed cronjobs' do
described_class.stubs(:target_object).returns File.new(my_fixture('managed'))
expect(described_class.instances.map do |p|
h = { name: p.get(:name) }
Puppet::Type.type(:cron).validproperties.each do |property|
h[property] = p.get(property)
end
h
end).to eq([
{
name: 'real_job',
minute: :absent,
hour: :absent,
weekday: :absent,
month: :absent,
monthday: :absent,
special: :absent,
command: '/bin/true',
ensure: :present,
environment: :absent,
user: :absent,
target: 'foobar',
},
{
name: 'complex_job',
minute: :absent,
hour: :absent,
weekday: :absent,
month: :absent,
monthday: :absent,
special: 'reboot',
command: '/bin/true >> /dev/null 2>&1',
ensure: :present,
environment: [
'MAILTO=foo@example.com',
'SHELL=/bin/sh',
],
user: :absent,
target: 'foobar',
},
])
end
end
end
describe '.match' do
describe 'normal records' do
it 'matches when all fields are the same' do
expect(described_class.match(record, resource[:name] => resource)).to eq(resource)
end
{
minute: ['0', '15', '31', '45'],
hour: ['8-18'],
monthday: ['30', '31'],
month: ['12', '23'],
weekday: ['4'],
command: '/bin/false',
target: 'nobody',
}.each_pair do |field, new_value|
it "should not match a record when #{field} does not match" do
record[field] = new_value
expect(described_class.match(record, resource[:name] => resource)).to be_falsey
end
end
end
describe 'special records' do
it 'matches when all fields are the same' do
expect(described_class.match(record_special, resource_special[:name] => resource_special)).to eq(resource_special)
end
{
special: 'monthly',
command: '/bin/false',
target: 'root',
}.each_pair do |field, new_value|
it "should not match a record when #{field} does not match" do
record_special[field] = new_value
expect(described_class.match(record_special, resource_special[:name] => resource_special)).to be_falsey
end
end
end
describe 'with a resource without a command' do
it 'does not raise an error' do
expect { described_class.match(record, resource_sparse[:name] => resource_sparse) }.not_to raise_error
end
end
end
end
|