From f6defe0f69d243d6608c37dd41337f9ea7dffb62 Mon Sep 17 00:00:00 2001 From: Josh Cooper Date: Wed, 22 Nov 2023 13:40:58 -0800 Subject: Move cron_core to GH issues * Update metadata * Use jira and static code analysis workflows * Drop commit check requirement See PA-5395 --- .github/workflows/jira.yml | 19 ++++++++++++++ .github/workflows/static_code_analysis.yaml | 40 ++--------------------------- metadata.json | 2 +- rakelib/commits.rake | 25 ------------------ 4 files changed, 22 insertions(+), 64 deletions(-) create mode 100644 .github/workflows/jira.yml delete mode 100644 rakelib/commits.rake diff --git a/.github/workflows/jira.yml b/.github/workflows/jira.yml new file mode 100644 index 0000000..a0d49d6 --- /dev/null +++ b/.github/workflows/jira.yml @@ -0,0 +1,19 @@ +--- +name: Export issue to Jira + +on: + issues: + types: [labeled] + +permissions: + issues: write + +jobs: + export: + uses: "puppetlabs/phoenix-github-actions/.github/workflows/jira.yml@main" + with: + jira-project: PA + jira-base-url: ${{ vars.jira_base_url }} + jira-user-email: ${{ vars.jira_user_email }} + secrets: + jira-api-token: ${{ secrets.JIRA_ISSUES_ACTION }} diff --git a/.github/workflows/static_code_analysis.yaml b/.github/workflows/static_code_analysis.yaml index 575cde7..62438da 100644 --- a/.github/workflows/static_code_analysis.yaml +++ b/.github/workflows/static_code_analysis.yaml @@ -6,44 +6,8 @@ on: branches: [ main ] pull_request: branches: [ main ] + workflow_dispatch: jobs: static_code_analysis: - name: Run checks - - env: - ruby_version: 2.6 - extra_checks: check:symlinks check:git_ignore check:dot_underscore check:test_file - - runs-on: 'ubuntu-20.04' - steps: - - name: Checkout current PR code - uses: actions/checkout@v4 - with: - fetch-depth: 0 - - - name: Install ruby version ${{ env.ruby_version }} - uses: ruby/setup-ruby@v1 - with: - ruby-version: ${{ env.ruby_version }} - - - name: Prepare testing environment with bundler - run: | - git config --global core.longpaths true - bundle config set --local without 'release' - bundle update --jobs 4 --retry 3 - - - name: Run commits check - run: bundle exec rake commits - - - name: Run rubocop check - run: bundle exec rake ${{ env.extra_checks }} rubocop - - - name: Run syntax check - run: bundle exec rake ${{ env.extra_checks }} syntax syntax:hiera syntax:manifests syntax:templates - - - name: Run lint check - run: bundle exec rake ${{ env.extra_checks }} lint - - - name: Run metadata_lint check - run: bundle exec rake ${{ env.extra_checks }} metadata_lint + uses: "puppetlabs/phoenix-github-actions/.github/workflows/static_code_analysis.yaml@main" diff --git a/metadata.json b/metadata.json index c18ede6..2c3a272 100644 --- a/metadata.json +++ b/metadata.json @@ -6,7 +6,7 @@ "license": "Apache-2.0", "source": "https://github.com/puppetlabs/puppetlabs-cron_core", "project_page": "https://github.com/puppetlabs/puppetlabs-cron_core", - "issues_url": "https://tickets.puppetlabs.com/projects/MODULES", + "issues_url": "https://github.com/puppetlabs/puppetlabs-cron_core/issues", "dependencies": [ ], diff --git a/rakelib/commits.rake b/rakelib/commits.rake deleted file mode 100644 index 7cee9fa..0000000 --- a/rakelib/commits.rake +++ /dev/null @@ -1,25 +0,0 @@ -desc "verify that commit summaries are properly formatted" -task(:commits) do - # This rake task looks at the summary from every commit from this branch not - # in the branch targeted for a PR. - commit_range = 'HEAD^..HEAD' - puts "Checking commits #{commit_range}" - %x{git log --no-merges --pretty=%s #{commit_range}}.each_line do |commit_summary| - # This regex tests for the currently supported commit summary tokens. - # The exception tries to explain it in more full. - if /^Release prep|\((maint|packaging|doc|docs|modules|pa-\d+)\)|revert/i.match(commit_summary).nil? - raise "\n\n\n\tPlease make sure that your commit summary (i.e. the first line of the commit message) starts with one of the following:\n" \ - "\t\t(PA-)\n" \ - "\t\t(MODULES-)\n" \ - "\t\t(docs)\n" \ - "\t\t(docs)(DOCUMENT-)\n" \ - "\t\t(packaging)\n" - "\t\t(maint)\n" \ - "\t\tRelease prep v\n" \ - "\n\tThis test for the commit summary is case-insensitive.\n\n\n" - else - puts "#{commit_summary}" - end - puts "...passed" - end -end -- cgit v1.2.3