| Age | Commit message (Collapse) | Author |
|---|
|
used in rpm based platforms
|
|
The `filetype` provider executes `crontab` using Puppet's execution API, which
returns ProcessOutput objects that inherit from String. See puppetlabs/puppet@732d450
The provider later uses String#gsub to strip off the HEADER. In Ruby 2.7, the
gsub method returns a new instance of ProcessOutput:
irb(main):002:0> Puppet::Util::Execution::ProcessOutput.new("# HEADER\n0 4 * * * /etc/init.d/script.sh\n", 0).gsub(/# HEADER/, '').class
=> Puppet::Util::Execution::ProcessOutput
If you later serialize the crontab entries to YAML using `puppet resource`, then
puppet warns about serializing unknown data types:
# puppet resource cron --to_yaml
Warning: Cron[unmanaged:/etc/init.d/script.sh-1]['command'] contains a Puppet::Util::Execution::ProcessOutput value. It will be converted to the String '/etc/init.d/script.sh'
This wasn't an issue with Ruby 3.2, because String#gsub always returns a String:
irb(main):002:0> Puppet::Util::Execution::ProcessOutput.new("# HEADER\n0 4 * * * /etc/init.d/script.sh\n", 0).gsub(/# HEADER/, '').class
=> String
This commit explicitly converts the ProcessOutput to a String so the provider
behaves consistently on all Ruby versions.
Fixes #61
|
|
Legacy facts are removed in Puppet 8. This commit updates a spec
file from using legacy facts to using structured facts.
|
|
In acb57af, we updated the module according to PDK template 7.2.1,
which updated puppetlabs_spec_helper. The updated version of
puppetlabs_spec_helper removed the Beaker rake task, which we use
for acceptance testing.
This commit adds the voxpupuli-acceptance gem, which re-adds the
Beaker rake task.
|
|
This commit addresses the Rubocop Style/RedundantBegin cop and
removes an explicit `begin` block in favor of implicit syntax.
|
|
Includes REFERENCE.md ToC fixes for MODULES-8183.
|
|
Took the safest route and disabled cops either globally in .rubocop.yml
for just for specific cases in lib/
|
|
Generated using:
$ pdk --version
2.2.0
$ pdk update --template-ref 2.2.0
|
|
|
|
When applying a cron manigest that contains leading zeroes in a periodic
attribute (hour, minute, month, monthday, weekday), puppet will strip
down the zeroes even if they are accepted by the system cron.
Now puppet will only convert to integer the periodic attributes when
validating them, but will not change the input from the manifest.
|
|
On Gentoo there's always a .keep_<package>-<slot> (e.g.,
.keep_cronbase-0) file inside the cron directory to ensure it's not
removed with rmdir. Since usernames are very unlikely to start with
.keep_, we can safely filter out these hidden files.
|
|
|
|
This is required to keep in line with our module release process.
|
|
We only want to run these tests on agents that shipped with PUP-9217's
changes. These are any agents newer than 5.5.8 in the 5.y release
stream, and any agents newer than 6.0.4 in the 6.y release stream.
|
|
|
|
PUP-9217 introduced the :raise_prefetch_errors option to the ParsedFile provider
base class that, when set, will fail any resources associated with a failed prefetch
target. Thus, when a file read error does occur, Puppet will fail all of
the resources associated with the failed crontab (target). This means
that the failed crontab will not be overwritten, thus fixing the issue
described in the ticket.
For more details, please refer to https://github.com/puppetlabs/puppet/commit/5b0fa987e5b7b27839e424ff16d59c7bf081c73a
|
|
This commit adds the following tests to the cron resource:
* A test to ensure that the crontab provider writes the crontab file of
a new user
* A test to ensure that the crontab provider fails to write the crontab
file of a nonexistent user
* A test to ensure that the crontab provider writes an originally
unauthorized user's crontab file _if_ Puppet authorizes them in the
middle of the run
These tests are part of the crontab provider's specifications and should
have been added before.
|
|
|
|
|
|
|
|
|
|
Commit 420049f2 in Puppet fixed the crontab filetype's #read method
to use Puppet::Util::Execution.execute instead of %x. This commit
updates the unit tests to account for this change.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
