aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-12-05Merge pull request #67 from shubhamshinde360/PA-5575mainShubham Shinde
(PA-5575) Add Amazon to display support in Puppet forge
2023-12-05(PA-5575) Add Amazon to display support in Puppet forgeShubham Shinde
2023-12-04Merge pull request #66 from shubhamshinde360/PA-5954Michael Hashizume
(PA-5954) Add Amazon linux to install the 'cronie' (instead of cron) module used in rpm based platforms
2023-12-04(PA-5954) Add Amazon linux to install the 'cronie' (instead of cron) module ↵Shubham Shinde
used in rpm based platforms
2023-11-27Merge pull request #65 from puppetlabs/release-prepJosh Cooper
Release prep v1.2.1
2023-11-28Release prep v1.2.1GitHub Action
2023-11-27Merge pull request #62 from joshcooper/stringify_process_outputcthorn42
Convert ProcessOutput to String explicitly
2023-11-22Convert ProcessOutput to String explicitlyJosh Cooper
The `filetype` provider executes `crontab` using Puppet's execution API, which returns ProcessOutput objects that inherit from String. See puppetlabs/puppet@732d450 The provider later uses String#gsub to strip off the HEADER. In Ruby 2.7, the gsub method returns a new instance of ProcessOutput: irb(main):002:0> Puppet::Util::Execution::ProcessOutput.new("# HEADER\n0 4 * * * /etc/init.d/script.sh\n", 0).gsub(/# HEADER/, '').class => Puppet::Util::Execution::ProcessOutput If you later serialize the crontab entries to YAML using `puppet resource`, then puppet warns about serializing unknown data types: # puppet resource cron --to_yaml Warning: Cron[unmanaged:/etc/init.d/script.sh-1]['command'] contains a Puppet::Util::Execution::ProcessOutput value. It will be converted to the String '/etc/init.d/script.sh' This wasn't an issue with Ruby 3.2, because String#gsub always returns a String: irb(main):002:0> Puppet::Util::Execution::ProcessOutput.new("# HEADER\n0 4 * * * /etc/init.d/script.sh\n", 0).gsub(/# HEADER/, '').class => String This commit explicitly converts the ProcessOutput to a String so the provider behaves consistently on all Ruby versions. Fixes #61
2023-11-22Merge pull request #63 from joshcooper/gh-issuesJosh Cooper
Move cron_core to GH issues
2023-11-22Move cron_core to GH issuesJosh Cooper
* Update metadata * Use jira and static code analysis workflows * Drop commit check requirement See PA-5395
2023-10-03Merge pull request #60 from mhashizume/PA-5804/main/checkout-actionJosh Cooper
(PA-5804) Update Checkout GitHub Action
2023-10-03(PA-5804) Update Checkout GitHub ActionMichael Hashizume
The Checkout GitHub Action v3 uses Node 16, which hit end-of-life on September 11, 2023. This commit updates all instances of the Checkout Action from v3 to v4.
2023-10-03(maint) Update commit checkMichael Hashizume
This commit updates the commits Rake check to include commit summaries that begin with the Puppet Agent (PA) Jira project and removes references to a non-existent CONTRIBUTION.md.
2023-04-20Merge pull request #58 from mhashizume/MODULES-11418/main/reusable-workflowsJosh Cooper
(MODULES-11418) Add unit test resuable workflows
2023-04-19(MODULES-11418) Add unit test resuable workflowsMichael Hashizume
This commit switches the GitHub Actions workflows for unit tests over to using the reusable workflows in puppetlabs/phoenix-github-actions.
2023-02-17Merge pull request #57 from mhashizume/MODULES-11371/main/legacy-factscthorn42
(MODULES-11371) Updates legacy facts
2023-02-17(MODULES-11371) Updates legacy factsMichael Hashizume
Legacy facts are removed in Puppet 8. This commit updates a spec file from using legacy facts to using structured facts.
2023-02-14Merge pull request #56 from puppetlabs/release-prepMichael Hashizume
Release prep v1.2.0
2023-02-14Release prep v1.2.0GitHub Action
2023-02-14Merge pull request #55 from mhashizume/MODULES-11371/main/puppet-8-prepJosh Cooper
(MODULES-11371) Updates PDK template
2023-02-14(MODULES-11371) Pin gems for auto releaseMichael Hashizume
Modeling after the learnings of the support team in commit puppetlabs/puppetlabs-puppet_metrics_collector@78dd858 This commit pins the github_changelog_generator gem to its latest version to make it work, and the concurrent-ruby to an older version to compensate for the version of PDK shipped in the dev-tools container image.
2023-02-14(MODULES-11371) Add Vox Beaker gemMichael Hashizume
In acb57af, we updated the module according to PDK template 7.2.1, which updated puppetlabs_spec_helper. The updated version of puppetlabs_spec_helper removed the Beaker rake task, which we use for acceptance testing. This commit adds the voxpupuli-acceptance gem, which re-adds the Beaker rake task.
2023-02-14(MODULES-11371) Change auto release Docker imageMichael Hashizume
The PDK Docker image does not contain any build tools, which causes the installation of gems that use native extensions to fail. This commit changes the Docker image used in the Auto Release GitHub Action from the PDK image to the Puppet dev-tools image, which contains packages like `make` necessary for building native extensions.
2023-02-10(maint) Rubocop implicit begin fixMichael Hashizume
This commit addresses the Rubocop Style/RedundantBegin cop and removes an explicit `begin` block in favor of implicit syntax.
2023-02-10(MODULES-11377) Update GitHub Action Ubuntu runnerMichael Hashizume
GitHub is deprecating Ubuntu 18.04 runners on April 1, 2023. This commit switches all Ubuntu 18.04 runners used in GitHub Actions to Ubuntu 20.04. https://github.blog/changelog/2022-08-09-github-actions-the-ubuntu-18-04-actions-runner-image-is-being-deprecated-and-will-be-removed-by-12-1-22/ This commit also updates all instances of the actions/checkout@v2 to actions/checkout@v3 in perparation for the former's deprecation as part of the NodeJS deprecation. https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/
2023-02-10(MODULES-11371) Updates PDK templateMichael Hashizume
This commit runs `pdk update` using the most recent template at the time (2.7.1) and updates metadata.json to allow Puppet versions < 9.0.0 in preparation for the release of Puppet 8.
2022-10-17Merge pull request #54 from cthorn42/maint/main/MODULES-11351_update_osx_runnerAria Li (she/her)
(MODULES-11351) Update the osx action runner to use latest
2022-10-13(MODULES-11351) Update the osx action runner to use latestChristopher Thorn
2022-02-16Merge pull request #52 from AriaXLi/nightly_puppet_gem_curl_redirectMichael Hashizume
(MODULES-11283) update curl for installing latest nightly build
2022-02-16(MODULES-11283) update curl for installing latest nightly buildAria Li
2022-02-15Merge pull request #51 from AriaXLi/nightly_puppet_gem_curl_redirectcthorn42
(maint) Add redirect to nightly puppet gem download
2022-02-15(maint) Add redirect to nightly puppet gem downloadAria Li
2022-01-24Merge pull request #50 from AriaXLi/PA-4133Michael Hashizume
(PA-4133) Add phoenix to CODEOWNERS
2022-01-21(PA-4133) Add phoenix to CODEOWNERSAria Li
2022-01-13Merge pull request #49 from ↵Gabriel Nagy
Dorin-Pleava/PUP-11370/github_actions_upgrade_windows (maint) Github workflow now uses windows 2019
2022-01-11(maint) Github workflow now uses windows 2019Dorin Pleava
Upgraded github actions to use windows 2019 instead of windows 2016 as it will be removed on March 15, 2022.
2021-12-28Merge pull request #48 from cthorn42/maint/main/add_pdk_gem_pinMichael Hashizume
(maint) Update the .sync.yaml file to have pinned async
2021-12-28(maint) Update the .sync.yaml file to have pinned asyncChristopher Thorn
Learned that we are using PDK to build the Gemfile, so added to the .sync.yaml file the async gem pinning.
2021-12-28Merge pull request #47 from cthorn42/maint/main/pin_async_gemMichael Hashizume
(maint) Pin the async gem
2021-12-28(maint) Pin the async gemChristopher Thorn
Async 2.0.0 requires Ruby 3, so we're pinning to 1.x.
2021-10-04Merge pull request #46 from puppetlabs/release-prepBobosila Victor
Release prep v1.1.0
2021-10-04Release prep v1.1.0GitHub Action
2021-10-04Merge pull request #44 from joshcooper/bump_jsonBobosila Victor
(maint) Bump templates to 2.2.0
2021-10-01(MODULES-11197) Update to pdk-templates 2.2.0Gabriel Nagy
Includes REFERENCE.md ToC fixes for MODULES-8183.
2021-09-22Merge pull request #45 from BobosilaVictor/MODULES-11167/add-rocky-to-modulesGabriel Nagy
(MODULES-11167)(MODULES-11191) Add RockyLinux && AlmaLinux to cron-core metadata
2021-09-22(MODULES-11167) && (MODULES-11191) Add RockyLinux && AlmaLinux to cron-core ↵Bobosila Victor
metadata
2021-08-17(maint) Fix rubocop errorsJosh Cooper
Took the safest route and disabled cops either globally in .rubocop.yml for just for specific cases in lib/
2021-08-17(maint) Update to pdk templates 2.2.0Josh Cooper
Generated using: $ pdk --version 2.2.0 $ pdk update --template-ref 2.2.0
2021-08-17(maint) Move extra commits rake task to rakelibJosh Cooper
Our `commits` rake task is not part of the standard template, so move it to the `rakelib` directory so it will be deleted when running `pdk update`
2021-08-17(maint) Restrict system gems to match pdk templatesJosh Cooper