Age | Commit message (Collapse) | Author |
|
Convert ProcessOutput to String explicitly
|
|
The `filetype` provider executes `crontab` using Puppet's execution API, which
returns ProcessOutput objects that inherit from String. See puppetlabs/puppet@732d450
The provider later uses String#gsub to strip off the HEADER. In Ruby 2.7, the
gsub method returns a new instance of ProcessOutput:
irb(main):002:0> Puppet::Util::Execution::ProcessOutput.new("# HEADER\n0 4 * * * /etc/init.d/script.sh\n", 0).gsub(/# HEADER/, '').class
=> Puppet::Util::Execution::ProcessOutput
If you later serialize the crontab entries to YAML using `puppet resource`, then
puppet warns about serializing unknown data types:
# puppet resource cron --to_yaml
Warning: Cron[unmanaged:/etc/init.d/script.sh-1]['command'] contains a Puppet::Util::Execution::ProcessOutput value. It will be converted to the String '/etc/init.d/script.sh'
This wasn't an issue with Ruby 3.2, because String#gsub always returns a String:
irb(main):002:0> Puppet::Util::Execution::ProcessOutput.new("# HEADER\n0 4 * * * /etc/init.d/script.sh\n", 0).gsub(/# HEADER/, '').class
=> String
This commit explicitly converts the ProcessOutput to a String so the provider
behaves consistently on all Ruby versions.
Fixes #61
|
|
Move cron_core to GH issues
|
|
* Update metadata
* Use jira and static code analysis workflows
* Drop commit check requirement
See PA-5395
|
|
(PA-5804) Update Checkout GitHub Action
|
|
The Checkout GitHub Action v3 uses Node 16, which hit end-of-life on
September 11, 2023.
This commit updates all instances of the Checkout Action from v3 to
v4.
|
|
This commit updates the commits Rake check to include commit summaries
that begin with the Puppet Agent (PA) Jira project and removes
references to a non-existent CONTRIBUTION.md.
|
|
(MODULES-11418) Add unit test resuable workflows
|
|
This commit switches the GitHub Actions workflows for unit tests
over to using the reusable workflows in
puppetlabs/phoenix-github-actions.
|
|
(MODULES-11371) Updates legacy facts
|
|
Legacy facts are removed in Puppet 8. This commit updates a spec
file from using legacy facts to using structured facts.
|
|
Release prep v1.2.0
|
|
|
|
(MODULES-11371) Updates PDK template
|
|
Modeling after the learnings of the support team in commit
puppetlabs/puppetlabs-puppet_metrics_collector@78dd858
This commit pins the github_changelog_generator gem to its latest
version to make it work, and the concurrent-ruby to an older version
to compensate for the version of PDK shipped in the dev-tools
container image.
|
|
In acb57af, we updated the module according to PDK template 7.2.1,
which updated puppetlabs_spec_helper. The updated version of
puppetlabs_spec_helper removed the Beaker rake task, which we use
for acceptance testing.
This commit adds the voxpupuli-acceptance gem, which re-adds the
Beaker rake task.
|
|
The PDK Docker image does not contain any build tools, which causes
the installation of gems that use native extensions to fail.
This commit changes the Docker image used in the Auto Release
GitHub Action from the PDK image to the Puppet dev-tools image,
which contains packages like `make` necessary for building native
extensions.
|
|
This commit addresses the Rubocop Style/RedundantBegin cop and
removes an explicit `begin` block in favor of implicit syntax.
|
|
GitHub is deprecating Ubuntu 18.04 runners on April 1, 2023. This
commit switches all Ubuntu 18.04 runners used in GitHub Actions to
Ubuntu 20.04.
https://github.blog/changelog/2022-08-09-github-actions-the-ubuntu-18-04-actions-runner-image-is-being-deprecated-and-will-be-removed-by-12-1-22/
This commit also updates all instances of the actions/checkout@v2
to actions/checkout@v3 in perparation for the former's deprecation
as part of the NodeJS deprecation.
https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/
|
|
This commit runs `pdk update` using the most recent template at the
time (2.7.1) and updates metadata.json to allow Puppet versions
< 9.0.0 in preparation for the release of Puppet 8.
|
|
(MODULES-11351) Update the osx action runner to use latest
|
|
|
|
(MODULES-11283) update curl for installing latest nightly build
|
|
|
|
(maint) Add redirect to nightly puppet gem download
|
|
|
|
(PA-4133) Add phoenix to CODEOWNERS
|
|
|
|
Dorin-Pleava/PUP-11370/github_actions_upgrade_windows
(maint) Github workflow now uses windows 2019
|
|
Upgraded github actions to use windows 2019 instead of windows 2016 as
it will be removed on March 15, 2022.
|
|
(maint) Update the .sync.yaml file to have pinned async
|
|
Learned that we are using PDK to build the Gemfile, so added to the .sync.yaml
file the async gem pinning.
|
|
(maint) Pin the async gem
|
|
Async 2.0.0 requires Ruby 3, so we're pinning to 1.x.
|
|
Release prep v1.1.0
|
|
|
|
(maint) Bump templates to 2.2.0
|
|
Includes REFERENCE.md ToC fixes for MODULES-8183.
|
|
(MODULES-11167)(MODULES-11191) Add RockyLinux && AlmaLinux to cron-core metadata
|
|
metadata
|
|
Took the safest route and disabled cops either globally in .rubocop.yml
for just for specific cases in lib/
|
|
Generated using:
$ pdk --version
2.2.0
$ pdk update --template-ref 2.2.0
|
|
Our `commits` rake task is not part of the standard template, so move it
to the `rakelib` directory so it will be deleted when running `pdk
update`
|
|
|
|
|
|
To avoid having to update this everytime we release a new agent
platform, it should be enough to specify the supported OS, without
specific versions. It is assumed that for each OS in metadata.json, the
versions supported are the same as what the agent itself supports.
|
|
|
|
(MODULES-10945) Core module spring cleaning 2021
|
|
Bump Ruby version in the static code analysis workflow to 2.6, as 2.5
will be EOL soon.
|
|
Update the workflow that tests with released Puppet gems to also test
with Puppet 7.
Remove testing with Puppet 5 from the workflows since it reached EOL.
|