Merge pull request #1 from jtappa/extract

Import the module

8 files changed, 308 insertions, 0 deletions

diff --git a/spec/acceptance/tests/resource/cron/should_allow_changing_parameters_spec.rb b/spec/acceptance/tests/resource/cron/should_allow_changing_parameters_spec.rb
new file mode 100644
index 0000000..615d617
--- /dev/null
+++ b/spec/acceptance/tests/resource/cron/should_allow_changing_parameters_spec.rb
@@ -0,0 +1,63 @@
+require 'spec_helper_acceptance'
+
+RSpec.context 'when changing parameters' do
+  before(:each) do
+    compatible_agents.each do |agent|
+      step 'ensure the user exists via puppet'
+      setup agent
+    end
+  end
+
+  after(:each) do
+    compatible_agents.each do |agent|
+      step 'Cron: cleanup'
+      clean agent
+    end
+  end
+
+  compatible_agents.each do |agent|
+    it "manages cron entries on #{agent}" do
+      step 'Cron: basic - verify that it can be created'
+      result = apply_manifest_on(agent, 'cron { "myjob": command => "/bin/false", user    => "tstuser", hour    => "*", minute  => [1], ensure  => present,}')
+      expect(result.stdout).to match(%r{ensure: created})
+      result = run_cron_on(agent, :list, 'tstuser')
+      expect(result.stdout).to match(%r{.bin.false})
+
+      step 'Cron: allow changing command'
+      result = apply_manifest_on(agent, 'cron { "myjob": command => "/bin/true", user    => "tstuser", hour    => "*", minute  => [1], ensure  => present,}')
+      expect(result.stdout).to match(%r{command changed '.bin.false'.* to '.bin.true'})
+
+      result = run_cron_on(agent, :list, 'tstuser')
+      expect(result.stdout).to match(%r{1 . . . . .bin.true})
+
+      step 'Cron: allow changing time'
+      result = apply_manifest_on(agent, 'cron { "myjob": command => "/bin/true", user    => "tstuser", hour    => "1", minute  => [1], ensure  => present,}')
+      expect(result.stdout).to match(%r{hour: defined 'hour' as \['1'\]})
+
+      result = run_cron_on(agent, :list, 'tstuser')
+      expect(result.stdout).to match(%r{1 1 . . . .bin.true})
+
+      step 'Cron: allow changing time(array)'
+      result = apply_manifest_on(agent, 'cron { "myjob": command => "/bin/true", user    => "tstuser", hour    => ["1","2"], minute  => [1], ensure  => present,}')
+      expect(result.stdout).to match(%r{hour: hour changed \['1'\].* to \['1', '2'\]})
+
+      result = run_cron_on(agent, :list, 'tstuser')
+      expect(result.stdout).to match(%r{1 1,2 . . . .bin.true})
+
+      step 'Cron: allow changing time(array modification)'
+      result = apply_manifest_on(agent, 'cron { "myjob": command => "/bin/true", user    => "tstuser", hour    => ["3","2"], minute  => [1], ensure  => present,}')
+      expect(result.stdout).to match(%r{hour: hour changed \['1', '2'\].* to \['3', '2'\]})
+
+      result = run_cron_on(agent, :list, 'tstuser')
+      expect(result.stdout).to match(%r{1 3,2 . . . .bin.true})
+
+      step 'Cron: allow changing time(array modification to *)'
+      result = apply_manifest_on(agent, 'cron { "myjob": command => "/bin/true", user    => "tstuser", hour    => "*", minute  => "*", ensure  => present,}')
+      expect(result.stdout).to match(%r{minute: undefined 'minute' from \['1'\]})
+      expect(result.stdout).to match(%r{hour: undefined 'hour' from \['3', '2'\]})
+
+      result = run_cron_on(agent, :list, 'tstuser')
+      expect(result.stdout).to match(%r{\* \* . . . .bin.true})
+    end
+  end
+end
diff --git a/spec/acceptance/tests/resource/cron/should_be_idempotent_spec.rb b/spec/acceptance/tests/resource/cron/should_be_idempotent_spec.rb
new file mode 100644
index 0000000..35a91b7
--- /dev/null
+++ b/spec/acceptance/tests/resource/cron/should_be_idempotent_spec.rb
@@ -0,0 +1,32 @@
+require 'spec_helper_acceptance'
+
+RSpec.context 'when checking idempotency' do
+  before(:each) do
+    compatible_agents.each do |agent|
+      step 'ensure the user exists via puppet'
+      setup(agent)
+    end
+  end
+
+  after(:each) do
+    compatible_agents.each do |agent|
+      step 'Cron: cleanup'
+      clean(agent)
+    end
+  end
+
+  compatible_agents.each do |agent|
+    it "ensures idempotency on #{agent}" do
+      step 'Cron: basic - verify that it can be created'
+      result = apply_manifest_on(agent, 'cron { "myjob": command => "/bin/true", user    => "tstuser", hour    => "*", minute  => [1], ensure  => present,}')
+      expect(result.stdout).to match(%r{ensure: created})
+
+      result = run_cron_on(agent, :list, 'tstuser')
+      expect(result.stdout).to match(%r{. . . . . .bin.true})
+
+      step 'Cron: basic - should not create again'
+      result = apply_manifest_on(agent, 'cron { "myjob": command => "/bin/true", user    => "tstuser", hour    => "*", minute  => [1], ensure  => present,}')
+      expect(result.stdout).not_to match(%r{ensure: created})
+    end
+  end
+end
diff --git a/spec/acceptance/tests/resource/cron/should_create_cron_spec.rb b/spec/acceptance/tests/resource/cron/should_create_cron_spec.rb
new file mode 100644
index 0000000..05ae5e5
--- /dev/null
+++ b/spec/acceptance/tests/resource/cron/should_create_cron_spec.rb
@@ -0,0 +1,31 @@
+require 'spec_helper_acceptance'
+
+RSpec.context 'when creating cron' do
+  before(:each) do
+    compatible_agents.each do |agent|
+      step 'ensure the user exists via puppet'
+      setup(agent)
+    end
+  end
+
+  after(:each) do
+    compatible_agents.each do |agent|
+      step 'Cron: cleanup'
+      clean(agent)
+    end
+  end
+
+  compatible_agents.each do |host|
+    it 'creates a new cron job' do
+      step 'apply the resource on the host using puppet resource'
+      on(host, puppet_resource('cron', 'crontest', 'user=tstuser', 'command=/bin/true', 'ensure=present')) do
+        expect(stdout).to match(%r{created})
+      end
+
+      step 'verify that crontab -l contains what you expected'
+      run_cron_on(host, :list, 'tstuser') do
+        expect(stdout).to match(%r{\* \* \* \* \* /bin/true})
+      end
+    end
+  end
+end
diff --git a/spec/acceptance/tests/resource/cron/should_match_existing_spec.rb b/spec/acceptance/tests/resource/cron/should_match_existing_spec.rb
new file mode 100644
index 0000000..ce25be7
--- /dev/null
+++ b/spec/acceptance/tests/resource/cron/should_match_existing_spec.rb
@@ -0,0 +1,33 @@
+require 'spec_helper_acceptance'
+
+RSpec.context 'when matching cron' do
+  before(:each) do
+    compatible_agents.each do |agent|
+      step 'ensure the user exists via puppet'
+      setup(agent)
+      step 'Create the existing cron job by hand...'
+      run_cron_on(agent, :add, 'tstuser', '* * * * * /bin/true')
+    end
+  end
+
+  after(:each) do
+    compatible_agents.each do |agent|
+      step 'Cron: cleanup'
+      clean(agent)
+    end
+  end
+
+  compatible_agents.each do |host|
+    it 'matches existing cron jobs' do
+      step 'Apply the resource on the host using puppet resource'
+      on(host, puppet_resource('cron', 'crontest', 'user=tstuser', 'command=/bin/true', 'ensure=present')) do
+        expect(stdout).to match(%r{present})
+      end
+
+      step 'Verify that crontab -l contains what you expected'
+      run_cron_on(host, :list, 'tstuser') do
+        expect(stdout).to match(%r{\* \* \* \* \* /bin/true})
+      end
+    end
+  end
+end
diff --git a/spec/acceptance/tests/resource/cron/should_remove_cron_spec.rb b/spec/acceptance/tests/resource/cron/should_remove_cron_spec.rb
new file mode 100644
index 0000000..d23cded
--- /dev/null
+++ b/spec/acceptance/tests/resource/cron/should_remove_cron_spec.rb
@@ -0,0 +1,35 @@
+require 'spec_helper_acceptance'
+
+RSpec.context 'when removing crontab' do
+  before(:each) do
+    compatible_agents.each do |agent|
+      step 'ensure the user exists via puppet'
+      setup(agent)
+    end
+  end
+
+  after(:each) do
+    compatible_agents.each do |agent|
+      step 'Cron: cleanup'
+      clean(agent)
+    end
+  end
+
+  compatible_agents.each do |host|
+    it 'removes existing crontabs' do
+      step 'create the existing job by hand...'
+      run_cron_on(host, :add, 'tstuser', '* * * * * /bin/true')
+
+      step 'apply the resource on the host using puppet resource'
+      on(host, puppet_resource('cron', 'crontest', 'user=tstuser',
+                               'command=/bin/true', 'ensure=absent')) do
+        expect(stdout).to match(%r{crontest\D+ensure:\s+removed})
+      end
+
+      step ' contains what you expected'
+      run_cron_on(host, :list, 'tstuser') do
+        expect(stderr).not_to match(%r{/bin/true})
+      end
+    end
+  end
+end
diff --git a/spec/acceptance/tests/resource/cron/should_remove_leading_and_trailing_whitespace_spec.rb b/spec/acceptance/tests/resource/cron/should_remove_leading_and_trailing_whitespace_spec.rb
new file mode 100644
index 0000000..da04daa
--- /dev/null
+++ b/spec/acceptance/tests/resource/cron/should_remove_leading_and_trailing_whitespace_spec.rb
@@ -0,0 +1,41 @@
+require 'spec_helper_acceptance'
+
+RSpec.context 'when stripping whitespace from cron jobs' do
+  before(:each) do
+    compatible_agents.each do |agent|
+      step 'ensure the user exists via puppet'
+      setup(agent)
+    end
+  end
+
+  after(:each) do
+    compatible_agents.each do |agent|
+      step 'Cron: cleanup'
+      clean(agent)
+    end
+  end
+
+  agents.each do |host|
+    it 'removes leading and trailing whitespace from cron jobs' do
+      step 'apply the resource on the host using puppet resource'
+      on(host, puppet_resource('cron', 'crontest', 'user=tstuser', "command='   date > /dev/null    '", 'ensure=present')) do
+        expect(stdout).to match(%r{created})
+      end
+
+      step 'verify the added crontab entry has stripped whitespace'
+      run_cron_on(host, :list, 'tstuser') do
+        expect(stdout).to match(%r{\* \* \* \* \* date > .dev.null})
+      end
+
+      step 'apply the resource with trailing whitespace and check nothing happened'
+      on(host, puppet_resource('cron', 'crontest', 'user=tstuser', "command='date > /dev/null    '", 'ensure=present')) do
+        expect(stdout).not_to match(%r{ensure: created})
+      end
+
+      step 'apply the resource with leading whitespace and check nothing happened'
+      on(host, puppet_resource('cron', 'crontest', 'user=tstuser', "command='     date > /dev/null'", 'ensure=present')) do
+        expect(stdout).not_to match(%r{ensure: created})
+      end
+    end
+  end
+end
diff --git a/spec/acceptance/tests/resource/cron/should_remove_matching_spec.rb b/spec/acceptance/tests/resource/cron/should_remove_matching_spec.rb
new file mode 100644
index 0000000..652d8c5
--- /dev/null
+++ b/spec/acceptance/tests/resource/cron/should_remove_matching_spec.rb
@@ -0,0 +1,34 @@
+require 'spec_helper_acceptance'
+
+RSpec.context 'when removing crontabs' do
+  before(:each) do
+    compatible_agents.each do |agent|
+      step 'ensure the user exists via puppet'
+      setup(agent)
+
+      step 'create the existing job by hand...'
+      run_cron_on(agent, :add, 'tstuser', '* * * * * /bin/true')
+    end
+  end
+
+  after(:each) do
+    compatible_agents.each do |agent|
+      step 'Cron: cleanup'
+      clean(agent)
+    end
+  end
+
+  compatible_agents.each do |host|
+    it 'removes crontabs based on matching' do
+      step 'Remove cron resource'
+      on(host, puppet_resource('cron', 'bogus', 'user=tstuser', 'command=/bin/true', 'ensure=absent')) do
+        expect(stdout).to match(%r{bogus\D+ensure: removed})
+      end
+
+      step 'verify that crontab -l contains what you expected'
+      run_cron_on(host, :list, 'tstuser') do
+        expect(stdout.scan('/bin/true').length).to eq(0)
+      end
+    end
+  end
+end
diff --git a/spec/acceptance/tests/resource/cron/should_update_existing_spec.rb b/spec/acceptance/tests/resource/cron/should_update_existing_spec.rb
new file mode 100644
index 0000000..3b226e7
--- /dev/null
+++ b/spec/acceptance/tests/resource/cron/should_update_existing_spec.rb
@@ -0,0 +1,39 @@
+require 'spec_helper_acceptance'
+
+RSpec.context 'when updating cron jobs' do
+  before(:each) do
+    compatible_agents.each do |agent|
+      step 'ensure the user exists via puppet'
+      setup(agent)
+
+      step 'create the existing job by hand...'
+      run_cron_on(agent, :add, 'tstuser', '* * * * * /bin/true')
+    end
+  end
+
+  after(:each) do
+    compatible_agents.each do |agent|
+      step 'Cron: cleanup'
+      clean(agent)
+    end
+  end
+
+  compatible_agents.each do |host|
+    it 'updates existing cron entries' do
+      step 'verify that crontab -l contains what you expected'
+      run_cron_on(host, :list, 'tstuser') do
+        expect(stdout).to match(%r{\* \* \* \* \* /bin/true})
+      end
+
+      step 'apply the resource change on the host'
+      on(host, puppet_resource('cron', 'crontest', 'user=tstuser', 'command=/bin/true', 'ensure=present', "hour='0-6'")) do
+        expect(stdout).to match(%r{hour\s+=>\s+\['0-6'\]})
+      end
+
+      step 'verify that crontab -l contains what you expected'
+      run_cron_on(host, :list, 'tstuser') do
+        expect(stdout).to match(%r{\* 0-6 \* \* \* /bin/true})
+      end
+    end
+  end
+end