| Age | Commit message (Collapse) | Author |
|---|
|
Building on the new docs in https://github.com/ripienaar/puppet-concat/pull/20
|
|
add information about concat_basedir and the need for pluginsync = true at least once
|
|
least once
|
|
A patch to make puppet-concat better comply with community style guidelines.
|
|
Comply better with puppet community style guidelines.
Change-Id: Ie1782d266539b1a8f9890b2ade77280011aa22aa
|
|
Remove the gnu parameter from concat
|
|
Previously, the concatfragments.sh script was would default to using
GNU-specific flags for find, sort, and xargs. This necessitated
explicit passing of a "gnu = false" parameter to the concat define in
order to successfully run the script without GNU-specific flags when
working with systems that do not by default include GNU versions of the
utilities (solaris, for example).
This commit modifies the concatfragments script such that GNU versions
of the utilities are not needed at all. It does this while preserving
the original use case for the GNU flags, which was to allow special
characters (like spaces) in the filenames, which it accomplished by
using GNU flags to separate fields using null characters instead of
newlines.
In order to preserve backwards-compatibility with existing puppet
installations that make use of the "gnu = false" parameter, the
parameter list for the concat define has not been changed. Rather, the
gnu parameter is now deprecated and ignored.
|
|
* Zap the old copy of /usr/local/bin/concatfragments.sh.
* Fix comments to point at new location of script.
* Delete trailing whitespace.
|
|
Unset silly Nexenta environment variable.
|
|
Not sure how this is set in our puppet environment, but it is.
http://nexenta.org/projects/site/wiki/Personalities
|
|
Fix use of unqualified variable names
|
|
Fully qualify $::id, $::puppetversion, and $::concat_basedir.
|
|
use client's vardir - make module usable for unprivileged users
|
|
|
|
Fix for /bin/sh on Solaris.
|
|
-a file True if file exists. (Not available
in sh.)
|
|
updated to better support dash
|
|
To be able to use the module as an unprivileged user we need to
adjust certain things:
* only enforce the run user and group if we are root and can
actually change the user
* set owner/group of our files and directories to our own user/group
* place the concat script in a location we can write -> use the
concat dir for that.
|
|
Get the concat base directory from a fact -> makes it useable if
Puppet's :vardir is not /var/lib/puppet/. This fixes problems with
PE and makes the module also useable for puppet runs as
unpriviledged user.
|
|
|
|
As discussed .. Make $concatdir only readable by root.
|
|
|
|
That invocation of echo is not POSIX compliant: https://bugs.launchpad.net/ubuntu/+source/dash/+bug/72167
|
|
- use sh and not bash
|
|
|
|
|
|
|
|
and xargs; makes concat work on Solaris.
Add a $gnu parameter to make use of the aforementioned -g flag, and a $order parameter to make use of the -n flag in concatfragments.sh
|
|
|
|
The concat warn parameter can now be any string (and needs to include
the appropriate commenting character) and will then override the default
(which still gets printed when warn=>true).
Signed-off-by: martin f. krafft <madduck@madduck.net>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
