From e68bf62084b0a90097b3b65d3ef12c2605e09289 Mon Sep 17 00:00:00 2001
From: brettp <brettp@36083f99-b078-4883-b0ff-0f9b5a30f544>
Date: Fri, 11 Mar 2011 23:14:09 +0000
Subject: Refs #2991. First round at rearranging and grouping admin menu based
 upon tasks.

git-svn-id: http://code.elgg.org/elgg/trunk@8654 36083f99-b078-4883-b0ff-0f9b5a30f544
---
 views/default/admin/appearance/default_widgets.php | 65 ----------------------
 views/default/admin/appearance/menu_items.php      | 10 ----
 views/default/admin/appearance/profile_fields.php  | 18 ------
 .../admin/appearance/profile_fields/list.php       | 56 -------------------
 views/default/admin/settings/advanced.php          |  9 +++
 views/default/admin/settings/basic.php             |  9 +++
 views/default/admin/settings/default_widgets.php   | 65 ++++++++++++++++++++++
 views/default/admin/settings/menu_items.php        | 10 ++++
 views/default/admin/settings/profile_fields.php    | 18 ++++++
 .../default/admin/settings/profile_fields/list.php | 56 +++++++++++++++++++
 views/default/admin/sidebar.php                    | 15 ++++-
 views/default/admin/site/advanced.php              |  9 ---
 views/default/admin/site/basic.php                 |  9 ---
 views/default/css/admin.php                        | 16 +++---
 views/default/js/admin.php                         |  3 +
 15 files changed, 191 insertions(+), 177 deletions(-)
 delete mode 100644 views/default/admin/appearance/default_widgets.php
 delete mode 100644 views/default/admin/appearance/menu_items.php
 delete mode 100644 views/default/admin/appearance/profile_fields.php
 delete mode 100644 views/default/admin/appearance/profile_fields/list.php
 create mode 100644 views/default/admin/settings/advanced.php
 create mode 100644 views/default/admin/settings/basic.php
 create mode 100644 views/default/admin/settings/default_widgets.php
 create mode 100644 views/default/admin/settings/menu_items.php
 create mode 100644 views/default/admin/settings/profile_fields.php
 create mode 100644 views/default/admin/settings/profile_fields/list.php
 delete mode 100644 views/default/admin/site/advanced.php
 delete mode 100644 views/default/admin/site/basic.php

(limited to 'views/default')

diff --git a/views/default/admin/appearance/default_widgets.php b/views/default/admin/appearance/default_widgets.php
deleted file mode 100644
index 7462dfa7c..000000000
--- a/views/default/admin/appearance/default_widgets.php
+++ /dev/null
@@ -1,65 +0,0 @@
-<?php
-/**
- * Default widgets landing page.
- *
- * @package Elgg.Core
- * @subpackage Administration.DefaultWidgets
- */
-
-elgg_push_context('default_widgets');
-$widget_context = get_input('widget_context');
-$list = elgg_trigger_plugin_hook('get_list', 'default_widgets', null, array());
-
-// default to something if we can
-if (!$widget_context && $list) {
-	$widget_context = $list[0]['widget_context'];
-}
-
-$current_info = null;
-$tabs = array();
-foreach ($list as $info) {
-	$url = "admin/appearance/default_widgets?widget_context={$info['widget_context']}";
-	$selected = false;
-	if ($widget_context == $info['widget_context']) {
-		$selected = true;
-		$current_info = $info;
-	}
-
-	$tabs[] = array(
-		'title' => $info['name'],
-		'url' => $url,
-		'selected' => $selected
-	);
-}
-
-$tabs_vars = array(
-	'tabs' => $tabs
-);
-
-echo elgg_view('navigation/tabs', $tabs_vars);
-
-echo elgg_view('output/longtext', array('value' => elgg_echo('admin:appearance:default_widgets:instructions')));
-
-if (!$current_info) {
-	$content = elgg_echo('admin:appearance:default_widgets:unknown_type');
-} else {
-	// default widgets are owned and saved to the site.
-	elgg_set_page_owner_guid(elgg_get_config('site_guid'));
-	elgg_push_context($current_info['widget_context']);
-
-	$default_widgets_input = elgg_view('input/hidden', array(
-		'name' => 'default_widgets',
-		'value' => 1
-	));
-
-	$params = array(
-		'content' => $default_widgets_input,
-		'num_columns' => $current_info['widget_columns'],
-	);
-
-	$content = elgg_view_layout('widgets', $params);
-	elgg_pop_context();
-}
-elgg_pop_context();
-
-echo $content;
\ No newline at end of file
diff --git a/views/default/admin/appearance/menu_items.php b/views/default/admin/appearance/menu_items.php
deleted file mode 100644
index 4e35e032f..000000000
--- a/views/default/admin/appearance/menu_items.php
+++ /dev/null
@@ -1,10 +0,0 @@
-<?php
-/**
- * Elgg administration menu items
- *
- * @package Elgg
- * @subpackage Core
- */
-
-
-echo elgg_view_form('admin/menu/save');
diff --git a/views/default/admin/appearance/profile_fields.php b/views/default/admin/appearance/profile_fields.php
deleted file mode 100644
index 7077687cc..000000000
--- a/views/default/admin/appearance/profile_fields.php
+++ /dev/null
@@ -1,18 +0,0 @@
-<?php
-/**
- * Admin area: edit default profile fields
- */
-
-$add = elgg_view_form('profile/fields/add', array(), array());
-$list = elgg_view('admin/appearance/profile_fields/list');
-$reset = elgg_view_form('profile/fields/reset', array(), array());
-
-$body = <<<__HTML
-$add
-$list
-<div class="default_profile_reset">
-	$reset
-</div>
-__HTML;
-
-echo $body;
diff --git a/views/default/admin/appearance/profile_fields/list.php b/views/default/admin/appearance/profile_fields/list.php
deleted file mode 100644
index 493129583..000000000
--- a/views/default/admin/appearance/profile_fields/list.php
+++ /dev/null
@@ -1,56 +0,0 @@
-<?php
-/**
- * Profile fields.
- * 
- * @todo Needs some review
- */
-
-// List form elements
-$n = 0;
-$loaded_defaults = array();
-$items = array();
-if ($fieldlist = elgg_get_config('profile_custom_fields')) {
-	$fieldlistarray = explode(',', $fieldlist);
-	foreach ($fieldlistarray as $listitem) {
-		if ($translation = elgg_get_config("admin_defined_profile_{$listitem}")) {
-			$item = new stdClass;
-			$item->translation = $translation;
-			$item->shortname = $listitem;
-			$item->name = "admin_defined_profile_{$listitem}";
-			$item->type = elgg_get_config("admin_defined_profile_type_{$listitem}");
-			$items[] = $item;
-		}
-	}
-}
-?>
-<div id="list">
-	<ul id="sortable_profile_fields">
-<?php
-
-$save = elgg_echo('save');
-$cancel = elgg_echo('cancel');
-
-foreach ($items as $item) {
-	echo elgg_view("profile/", array('value' => $item->translation));
-
-	//$even_odd = ( 'odd' != $even_odd ) ? 'odd' : 'even';
-	$url = elgg_view('output/url', array(
-		'href' => "action/profile/fields/delete?id={$item->shortname}",
-		'is_action' => TRUE,
-		'text' => elgg_view_icon('delete'),
-	));
-	$type = elgg_echo($item->type);
-	echo <<<HTML
-<li id="$item->shortname" class="clearfix">
-	<span class="elgg-icon elgg-icon-dragger elgg-state-draggable"></span>
-	<b><span id="elgg-profile-field-{$item->shortname}" class="elgg-state-editable">$item->translation</span></b> [$type] $url
-</li>
-HTML;
-}
-
-?>
-	</ul>
-</div>
-<div id="tempList"></div>
-
-<input name="sortableListOrder" type="hidden" id="sortableListOrder" value="<?php echo $fieldlist; ?>" />
\ No newline at end of file
diff --git a/views/default/admin/settings/advanced.php b/views/default/admin/settings/advanced.php
new file mode 100644
index 000000000..12e4303e7
--- /dev/null
+++ b/views/default/admin/settings/advanced.php
@@ -0,0 +1,9 @@
+<?php
+/**
+ * Elgg administration site advanced settings
+ *
+ * @package Elgg
+ * @subpackage Core
+ */
+
+echo elgg_view_form('admin/site/update_advanced');
diff --git a/views/default/admin/settings/basic.php b/views/default/admin/settings/basic.php
new file mode 100644
index 000000000..3b8f4f183
--- /dev/null
+++ b/views/default/admin/settings/basic.php
@@ -0,0 +1,9 @@
+<?php
+/**
+ * Elgg administration site basic settings
+ *
+ * @package Elgg
+ * @subpackage Core
+ */
+
+echo elgg_view_form('admin/site/update_basic');
diff --git a/views/default/admin/settings/default_widgets.php b/views/default/admin/settings/default_widgets.php
new file mode 100644
index 000000000..ce9f6a5c2
--- /dev/null
+++ b/views/default/admin/settings/default_widgets.php
@@ -0,0 +1,65 @@
+<?php
+/**
+ * Default widgets landing page.
+ *
+ * @package Elgg.Core
+ * @subpackage Administration.DefaultWidgets
+ */
+
+elgg_push_context('default_widgets');
+$widget_context = get_input('widget_context');
+$list = elgg_trigger_plugin_hook('get_list', 'default_widgets', null, array());
+
+// default to something if we can
+if (!$widget_context && $list) {
+	$widget_context = $list[0]['widget_context'];
+}
+
+$current_info = null;
+$tabs = array();
+foreach ($list as $info) {
+	$url = "admin/settings/default_widgets?widget_context={$info['widget_context']}";
+	$selected = false;
+	if ($widget_context == $info['widget_context']) {
+		$selected = true;
+		$current_info = $info;
+	}
+
+	$tabs[] = array(
+		'title' => $info['name'],
+		'url' => $url,
+		'selected' => $selected
+	);
+}
+
+$tabs_vars = array(
+	'tabs' => $tabs
+);
+
+echo elgg_view('navigation/tabs', $tabs_vars);
+
+echo elgg_view('output/longtext', array('value' => elgg_echo('admin:default_widgets:instructions')));
+
+if (!$current_info) {
+	$content = elgg_echo('admin:default_widgets:unknown_type');
+} else {
+	// default widgets are owned and saved to the site.
+	elgg_set_page_owner_guid(elgg_get_config('site_guid'));
+	elgg_push_context($current_info['widget_context']);
+
+	$default_widgets_input = elgg_view('input/hidden', array(
+		'name' => 'default_widgets',
+		'value' => 1
+	));
+
+	$params = array(
+		'content' => $default_widgets_input,
+		'num_columns' => $current_info['widget_columns'],
+	);
+
+	$content = elgg_view_layout('widgets', $params);
+	elgg_pop_context();
+}
+elgg_pop_context();
+
+echo $content;
diff --git a/views/default/admin/settings/menu_items.php b/views/default/admin/settings/menu_items.php
new file mode 100644
index 000000000..4e35e032f
--- /dev/null
+++ b/views/default/admin/settings/menu_items.php
@@ -0,0 +1,10 @@
+<?php
+/**
+ * Elgg administration menu items
+ *
+ * @package Elgg
+ * @subpackage Core
+ */
+
+
+echo elgg_view_form('admin/menu/save');
diff --git a/views/default/admin/settings/profile_fields.php b/views/default/admin/settings/profile_fields.php
new file mode 100644
index 000000000..e9dc609e3
--- /dev/null
+++ b/views/default/admin/settings/profile_fields.php
@@ -0,0 +1,18 @@
+<?php
+/**
+ * Admin area: edit default profile fields
+ */
+
+$add = elgg_view_form('profile/fields/add', array(), array());
+$list = elgg_view('admin/settings/profile_fields/list');
+$reset = elgg_view_form('profile/fields/reset', array(), array());
+
+$body = <<<__HTML
+$add
+$list
+<div class="default_profile_reset">
+	$reset
+</div>
+__HTML;
+
+echo $body;
diff --git a/views/default/admin/settings/profile_fields/list.php b/views/default/admin/settings/profile_fields/list.php
new file mode 100644
index 000000000..493129583
--- /dev/null
+++ b/views/default/admin/settings/profile_fields/list.php
@@ -0,0 +1,56 @@
+<?php
+/**
+ * Profile fields.
+ * 
+ * @todo Needs some review
+ */
+
+// List form elements
+$n = 0;
+$loaded_defaults = array();
+$items = array();
+if ($fieldlist = elgg_get_config('profile_custom_fields')) {
+	$fieldlistarray = explode(',', $fieldlist);
+	foreach ($fieldlistarray as $listitem) {
+		if ($translation = elgg_get_config("admin_defined_profile_{$listitem}")) {
+			$item = new stdClass;
+			$item->translation = $translation;
+			$item->shortname = $listitem;
+			$item->name = "admin_defined_profile_{$listitem}";
+			$item->type = elgg_get_config("admin_defined_profile_type_{$listitem}");
+			$items[] = $item;
+		}
+	}
+}
+?>
+<div id="list">
+	<ul id="sortable_profile_fields">
+<?php
+
+$save = elgg_echo('save');
+$cancel = elgg_echo('cancel');
+
+foreach ($items as $item) {
+	echo elgg_view("profile/", array('value' => $item->translation));
+
+	//$even_odd = ( 'odd' != $even_odd ) ? 'odd' : 'even';
+	$url = elgg_view('output/url', array(
+		'href' => "action/profile/fields/delete?id={$item->shortname}",
+		'is_action' => TRUE,
+		'text' => elgg_view_icon('delete'),
+	));
+	$type = elgg_echo($item->type);
+	echo <<<HTML
+<li id="$item->shortname" class="clearfix">
+	<span class="elgg-icon elgg-icon-dragger elgg-state-draggable"></span>
+	<b><span id="elgg-profile-field-{$item->shortname}" class="elgg-state-editable">$item->translation</span></b> [$type] $url
+</li>
+HTML;
+}
+
+?>
+	</ul>
+</div>
+<div id="tempList"></div>
+
+<input name="sortableListOrder" type="hidden" id="sortableListOrder" value="<?php echo $fieldlist; ?>" />
\ No newline at end of file
diff --git a/views/default/admin/sidebar.php b/views/default/admin/sidebar.php
index b2c520705..a6c16c758 100644
--- a/views/default/admin/sidebar.php
+++ b/views/default/admin/sidebar.php
@@ -1,8 +1,17 @@
 <?php
 /**
- * Admin sidebar -- just outputs the page menu
+ * Admin sidebar -- just outputs the page menus
  */
+$sections = array('administer', 'configure', 'develop');
+$content = '';
 
-$content = elgg_view_menu('page', array('sort_by' => 'priority'));
+foreach ($sections as $section) {
+	$section_content = elgg_view_menu("admin-$section", array('sort_by' => 'priority', 'class' => 'mbl mts'));
+	
+	if ($section_content) {
+		$content .= '<h2>' . elgg_echo("admin:$section") . '</h2>';
+		$content .= $section_content;
+	}
+}
 
-echo elgg_view_module('main', '', $content);
\ No newline at end of file
+echo elgg_view_module('main', '', $content, array('class' => 'elgg-admin-sidebar-menu'));
\ No newline at end of file
diff --git a/views/default/admin/site/advanced.php b/views/default/admin/site/advanced.php
deleted file mode 100644
index 12e4303e7..000000000
--- a/views/default/admin/site/advanced.php
+++ /dev/null
@@ -1,9 +0,0 @@
-<?php
-/**
- * Elgg administration site advanced settings
- *
- * @package Elgg
- * @subpackage Core
- */
-
-echo elgg_view_form('admin/site/update_advanced');
diff --git a/views/default/admin/site/basic.php b/views/default/admin/site/basic.php
deleted file mode 100644
index 3b8f4f183..000000000
--- a/views/default/admin/site/basic.php
+++ /dev/null
@@ -1,9 +0,0 @@
-<?php
-/**
- * Elgg administration site basic settings
- *
- * @package Elgg
- * @subpackage Core
- */
-
-echo elgg_view_form('admin/site/update_basic');
diff --git a/views/default/css/admin.php b/views/default/css/admin.php
index 1a8747f3a..3a3c8eb16 100644
--- a/views/default/css/admin.php
+++ b/views/default/css/admin.php
@@ -266,7 +266,8 @@ table.mceLayout {
 /* ***************************************
 	SIDEBAR MENU
 *************************************** */
-.elgg-menu-page a {
+.elgg-admin-sidebar-menu a {
+	border: 1px solid red;
 	display: block;
 	padding: 5px;
 	color: #333333;
@@ -279,31 +280,32 @@ table.mceLayout {
 	-moz-border-radius: 5px;
 	border-radius: 5px;
 }
-.elgg-menu-page a:hover {
+
+.elgg-admin-sidebar-menu a:hover {
 	text-decoration: none;
 	background: black;
 	color: white;
 	border: 1px solid black;
 }
-.elgg-menu-page li.elgg-state-selected > a {
+.elgg-admin-sidebar-menu li.elgg-state-selected > a {
 	background-color: #BBB;
 }
 
-.elgg-menu-page .elgg-menu-closed:before {
+.elgg-admin-sidebar-menu .elgg-menu-closed:before {
 	content: "\25B8";
 	padding-right: 4px;
 }
 
-.elgg-menu-page .elgg-menu-opened:before {
+.elgg-admin-sidebar-menu .elgg-menu-opened:before {
 	content: "\25BE";
 	padding-right: 4px;
 }
 
-.elgg-menu-page .elgg-child-menu {
+.elgg-admin-sidebar-menu .elgg-child-menu {
 	display: none;
 	padding-left: 30px;
 }
-.elgg-menu-page li.elgg-state-selected > ul {
+.elgg-admin-sidebar-menu li.elgg-state-selected > ul {
 	display: block;
 }
 
diff --git a/views/default/js/admin.php b/views/default/js/admin.php
index 15c74d4de..d37dc7a81 100644
--- a/views/default/js/admin.php
+++ b/views/default/js/admin.php
@@ -16,6 +16,9 @@ elgg.admin.init = function () {
 		$(this).stop().slideUp('medium');
 	});
 
+	// semi-custom menus
+	$('.elgg-admin-sidebar-menu .elgg-menu-parent').live('click', elgg.ui.toggleMenu);
+
 	// plugin screenshot modal
 	$('.elgg-plugin-screenshot a').click(elgg.admin.displayPluginScreenshot);
 
-- 
cgit v1.2.3