From 74a2c0f73100209d1c10259a3f862d3645ab5dbb Mon Sep 17 00:00:00 2001 From: capo Date: Sun, 12 Jan 2014 18:21:24 +0100 Subject: review code from hellekin comments --- views/default/simplepie/group_module.php | 106 +++++++++++++++---------------- 1 file changed, 53 insertions(+), 53 deletions(-) (limited to 'views/default/simplepie/group_module.php') diff --git a/views/default/simplepie/group_module.php b/views/default/simplepie/group_module.php index 7d0a7bc2f..17b2dba0c 100644 --- a/views/default/simplepie/group_module.php +++ b/views/default/simplepie/group_module.php @@ -17,7 +17,7 @@ $feed_url = $group->feed_url; $content = ''; if ($group->canEdit()) { - $content .= elgg_view_form("simplepie/group_module", array( + $content .= elgg_view_form("simplepie/save_group_feed", array( 'id' => 'simplepie-form', 'class' => $feed_url ? 'hidden' : '', ), $vars); @@ -25,64 +25,66 @@ if ($group->canEdit()) { if ($feed_url) { - // get widget settings - $excerpt = true; - $post_date = true; +// get widget settings + $excerpt = true; + $post_date = true; $num_items = 7; - $cache_location = elgg_get_data_path() . '/simplepie_cache/'; - if (!file_exists($cache_location)) { - mkdir($cache_location, 0777); - } + $cache_location = elgg_get_data_path() . '/simplepie_cache/'; + if (!file_exists($cache_location)) { + mkdir($cache_location, 0777); + } - $feed = new SimplePie($feed_url, $cache_location); + $feed = new SimplePie($feed_url, $cache_location); - // doubles timeout if going through a proxy - //$feed->set_timeout(20); +// doubles timeout if going through a proxy +//$feed->set_timeout(20); - // only display errors to profile owner - $num_posts_in_feed = $feed->get_item_quantity(); - if (!$num_posts_in_feed) { - if (elgg_get_logged_in_user_guid() == elgg_get_page_owner_guid()) { - $content .= '

' . elgg_echo('simplepie:notfind') . '

'; - } - } - // don't display more feed items than user requested - if ($num_items > $num_posts_in_feed) { - $num_items = $num_posts_in_feed; - } +// only display errors to profile owner + $num_posts_in_feed = $feed->get_item_quantity(); +if (!$num_posts_in_feed) { + if (elgg_get_logged_in_user_guid() == elgg_get_page_owner_guid()) { + $content .= '

' . elgg_echo('simplepie:notfound') . '

'; + } +} + +// don't display more feed items than user requested + if ($num_items > $num_posts_in_feed) { + $num_items = $num_posts_in_feed; +} + + $feed_link = elgg_view('output/url', array( + 'href' => $feed->get_permalink(), + 'text' => $feed->get_title(), +)); + +// need to center + $content .= "

$feed_link

"; + $content .= '