From b60c540bccaeb39704418a3d458427730e06c42d Mon Sep 17 00:00:00 2001 From: cash Date: Thu, 30 Dec 2010 19:46:56 +0000 Subject: more html validation cleanup git-svn-id: http://code.elgg.org/elgg/trunk@7776 36083f99-b078-4883-b0ff-0f9b5a30f544 --- views/default/output/confirmlink.php | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) (limited to 'views/default/output') diff --git a/views/default/output/confirmlink.php b/views/default/output/confirmlink.php index 5cb9aa52e..6d575b9ae 100644 --- a/views/default/output/confirmlink.php +++ b/views/default/output/confirmlink.php @@ -9,15 +9,15 @@ * @uses $vars['text'] The text of the link * @uses $vars['href'] The address * @uses $vars['confirm'] The dialog text - * @uses $vars['encode'] Encode special characters? + * @uses $vars['text_encode'] Encode special characters? */ $confirm = elgg_get_array_value('confirm', $vars, elgg_echo('question:areyousure')); -$encode = elgg_get_array_value('encode', $vars, true); +$encode = elgg_get_array_value('text_encode', $vars, true); // always generate missing action tokens -$link = elgg_add_action_tokens_to_url(elgg_normalize_url($vars['href'])); +$vars['href'] = elgg_add_action_tokens_to_url(elgg_normalize_url($vars['href']), true); $text = elgg_get_array_value('text', $vars, ''); if ($encode) { @@ -29,7 +29,12 @@ if (isset($vars['class']) && $vars['class']) { } else { $class = ''; } -?> - onclick="return confirm('');"> - - + +$vars['onclick'] = "return confirm('" . addslashes($confirm) . "')"; + +unset($vars['encode_text']); +unset($vars['text']); +unset($vars['confirm']); + +$attributes = elgg_format_attributes($vars); +echo "$text"; -- cgit v1.2.3