From 767d259bb89a337ec57abeeb8c3ac5c5fc3e9d21 Mon Sep 17 00:00:00 2001
From: ewinslow <ewinslow@36083f99-b078-4883-b0ff-0f9b5a30f544>
Date: Fri, 11 Feb 2011 23:09:33 +0000
Subject: Added disapproving @todo's wherever I could find javascript not
 conforming to 1.8 conventions

git-svn-id: http://code.elgg.org/elgg/trunk@8123 36083f99-b078-4883-b0ff-0f9b5a30f544
---
 .../notifications/subscriptions/collections.php    |  2 +-
 .../notifications/subscriptions/forminternals.php  | 32 +++++++++++-----------
 .../notifications/subscriptions/jsfuncs.php        |  2 +-
 3 files changed, 18 insertions(+), 18 deletions(-)

(limited to 'mod/notifications')

diff --git a/mod/notifications/views/default/notifications/subscriptions/collections.php b/mod/notifications/views/default/notifications/subscriptions/collections.php
index 765998e0e..8daae6f4f 100644
--- a/mod/notifications/views/default/notifications/subscriptions/collections.php
+++ b/mod/notifications/views/default/notifications/subscriptions/collections.php
@@ -1,4 +1,4 @@
-
+<?php //@todo JS 1.8: no ?>
 <script type="text/javascript">
 	
 	function setCollection(members, method, id) {
diff --git a/mod/notifications/views/default/notifications/subscriptions/forminternals.php b/mod/notifications/views/default/notifications/subscriptions/forminternals.php
index c8989be26..98ca1ccb5 100644
--- a/mod/notifications/views/default/notifications/subscriptions/forminternals.php
+++ b/mod/notifications/views/default/notifications/subscriptions/forminternals.php
@@ -118,7 +118,7 @@ if (!isset($vars['replacement'])) {
 	
 	if ($formtarget) {
 ?>
-
+<?php //@todo JS 1.8: no ?>
 	<script language="text/javascript">
 		$(function() { // onload...do
 		$('#collectionMembersForm<?php echo $friendspicker; ?>').submit(function() {
@@ -133,13 +133,13 @@ if (!isset($vars['replacement'])) {
 				data: inputs.join('&'),
 				url: this.action,
 				success: function(){
-     				$('a.collectionmembers<?php echo $friendspicker; ?>').click();
-   				}
+					$('a.collectionmembers<?php echo $friendspicker; ?>').click();
+				}
 
 			});
 			return false;
-        })
-      })
+		})
+	})
 
 	</script>
 
@@ -173,8 +173,8 @@ if (!isset($vars['replacement'])) {
 ?>
 
 <table id="notificationstable" cellspacing="0" cellpadding="4" border="0" width="100%">
-  <tr>
-    <td>&nbsp;</td>
+<tr>
+	<td>&nbsp;</td>
 <?php
 			$i = 0;
 			foreach($NOTIFICATION_HANDLERS as $method => $foo) {
@@ -187,8 +187,8 @@ if (!isset($vars['replacement'])) {
 				$i++;
 			}
 ?>
-    <td>&nbsp;</td>
-  </tr>
+	<td>&nbsp;</td>
+</tr>
 
 <?php
 
@@ -222,8 +222,8 @@ END;
 						}
 ?>
 
-  <tr>
-    <td class="namefield">
+<tr>
+	<td class="namefield">
 		<a href="<?php echo $friend->getURL(); ?>">
 <?php
 						echo elgg_view("profile/icon",array('entity' => $friend, 'size' => 'tiny', 'override' => true));
@@ -233,11 +233,11 @@ END;
 			<a href="<?php echo $friend->getURL(); ?>"><?php echo $friend->name ?></a>
 		</p>
 	</td>
-    
+	
 <?php echo $fields; ?>
-  
-  <td>&nbsp;</td>
-  </tr>
+
+<td>&nbsp;</td>
+</tr>
 
 
 <?php
@@ -288,7 +288,7 @@ if (!$callback) {
 <?php
 if (!isset($vars['replacement'])) {
 ?>
-
+<?php //@todo JS 1.8: no ?>
 <script type="text/javascript">
 		// initialise picker
 		$("div#friends-picker<?php echo $friendspicker; ?>").friendsPicker(<?php echo $friendspicker; ?>);
diff --git a/mod/notifications/views/default/notifications/subscriptions/jsfuncs.php b/mod/notifications/views/default/notifications/subscriptions/jsfuncs.php
index d94edf9ef..ace622581 100644
--- a/mod/notifications/views/default/notifications/subscriptions/jsfuncs.php
+++ b/mod/notifications/views/default/notifications/subscriptions/jsfuncs.php
@@ -3,7 +3,7 @@
 global $NOTIFICATION_HANDLERS;
 
 ?> 
-
+<?php //@todo JS 1.8: no ?>
 <script type="text/javascript">
 
 $(document).ready(function () {
-- 
cgit v1.2.3