diff options
Diffstat (limited to 'mod/embed/views/default')
| -rw-r--r-- | mod/embed/views/default/embed/embed.php | 1 | ||||
| -rw-r--r-- | mod/embed/views/default/embed/item/gallery.php | 2 | ||||
| -rw-r--r-- | mod/embed/views/default/embed/item/list.php | 2 | ||||
| -rw-r--r-- | mod/embed/views/default/embed/metatags.php | 5 | ||||
| -rw-r--r-- | mod/embed/views/default/embed/upload/content.php | 1 |
5 files changed, 7 insertions, 4 deletions
diff --git a/mod/embed/views/default/embed/embed.php b/mod/embed/views/default/embed/embed.php index e839450da..9b875fdeb 100644 --- a/mod/embed/views/default/embed/embed.php +++ b/mod/embed/views/default/embed/embed.php @@ -123,6 +123,7 @@ if (!$sections) { echo $content; ?> +<?php //@todo: JS 1.8: ugly ?> <script type="text/javascript"> $(document).ready(function() { var internal_name = '<?php echo addslashes($internal_name); ?>'; diff --git a/mod/embed/views/default/embed/item/gallery.php b/mod/embed/views/default/embed/item/gallery.php index 52c0966fa..daee8ee94 100644 --- a/mod/embed/views/default/embed/item/gallery.php +++ b/mod/embed/views/default/embed/item/gallery.php @@ -47,7 +47,7 @@ $info = htmlentities($title, ENT_QUOTES, 'UTF-8'); $listing = elgg_view('entities/gallery_listing', array('icon' => $icon, 'info' => $info)); -// @todo is this approach better than inline js? +// @todo JS 1.8: no echo "<div class=\"embed_data\" id=\"embed_{$item->getGUID()}\">$listing</div>"; echo "<script type=\"text/javascript\"> $('#embed_{$item->getGUID()}').data('embed_code', " . json_encode($embed_code) . "); diff --git a/mod/embed/views/default/embed/item/list.php b/mod/embed/views/default/embed/item/list.php index fc5545df0..c5c604854 100644 --- a/mod/embed/views/default/embed/item/list.php +++ b/mod/embed/views/default/embed/item/list.php @@ -44,7 +44,7 @@ $icon = "<img src=\"{$item->getIcon($icon_size)}\" />"; $info = "<p class='entity-title'>" . htmlentities($title, ENT_QUOTES, 'UTF-8') . "</p>"; $info .= "<p class='entity-subtext'>" . elgg_view_friendly_time($vars['item']->time_created) . "</p>"; -// @todo is this approach better than inline js? +// @todo JS 1.8: is this approach better than inline js? echo "<div class=\"embed_data\" id=\"embed_{$item->getGUID()}\">" . elgg_view_listing($icon, $info) . '</div>'; echo "<script type=\"text/javascript\"> $('#embed_{$item->getGUID()}').data('embed_code', " . json_encode($embed_code) . "); diff --git a/mod/embed/views/default/embed/metatags.php b/mod/embed/views/default/embed/metatags.php index 3c7ab87a9..5ff602362 100644 --- a/mod/embed/views/default/embed/metatags.php +++ b/mod/embed/views/default/embed/metatags.php @@ -1,5 +1,6 @@ + <?php //@todo JS 1.8: no ?> <script type="text/javascript"> - jQuery(document).ready(function($) { - $('a[rel*=facebox]').facebox() + jQuery(document).ready(function($) { + $('a[rel*=facebox]').facebox() }); </script> diff --git a/mod/embed/views/default/embed/upload/content.php b/mod/embed/views/default/embed/upload/content.php index bac8e1393..874ed44b1 100644 --- a/mod/embed/views/default/embed/upload/content.php +++ b/mod/embed/views/default/embed/upload/content.php @@ -29,6 +29,7 @@ if ($upload_sections) { echo $upload_content . "</div>"; ?> + <?php //@todo: JS 1.8: ugly ?> <script type="text/javascript"> $(document).ready(function() { |