diff options
author | cash <cash@36083f99-b078-4883-b0ff-0f9b5a30f544> | 2011-02-12 14:37:08 +0000 |
---|---|---|
committer | cash <cash@36083f99-b078-4883-b0ff-0f9b5a30f544> | 2011-02-12 14:37:08 +0000 |
commit | 7f79364447b07bac67d2c20cc3c1b404e8c94dc3 (patch) | |
tree | 8ccc0f26936f9e979bf626e443b2af2ded8f1287 /views/default/input | |
parent | fe4289cad423370fb2635b204dbdb5b53563b7be (diff) | |
download | elgg-7f79364447b07bac67d2c20cc3c1b404e8c94dc3.tar.gz elgg-7f79364447b07bac67d2c20cc3c1b404e8c94dc3.tar.bz2 |
Refs #1393 added work around note to checkboxes and radio inputs for integer labels
git-svn-id: http://code.elgg.org/elgg/trunk@8156 36083f99-b078-4883-b0ff-0f9b5a30f544
Diffstat (limited to 'views/default/input')
-rw-r--r-- | views/default/input/checkboxes.php | 9 | ||||
-rw-r--r-- | views/default/input/radio.php | 6 |
2 files changed, 12 insertions, 3 deletions
diff --git a/views/default/input/checkboxes.php b/views/default/input/checkboxes.php index 85c44de54..16d13ef66 100644 --- a/views/default/input/checkboxes.php +++ b/views/default/input/checkboxes.php @@ -2,10 +2,15 @@ /** * Elgg checkbox input * Displays a checkbox input field - * NB: This also includes a hidden input with the same name as the checkboxes + * + * @note This also includes a hidden input with the same name as the checkboxes * to make sure something is sent to the server. The default value is 0. * If using JS, be specific to avoid selecting the hidden default value: * $('input[type=checkbox][name=internalname]') + * + * @warning Passing integers as labels does not currently work due to a + * deprecated hack that will be removed in Elgg 1.9. To use integer labels, + * the labels must be character codes: 1 would be 1 * * @package Elgg * @subpackage Core @@ -50,7 +55,7 @@ if ($options && count($options) > 0) { echo "<ul class=\"$class\">"; foreach ($options as $label => $option) { - // @deprecated 1.8 + // @deprecated 1.8 Remove in 1.9 if (is_integer($label)) { elgg_deprecated_notice('$vars[\'options\'] must be an associative array in input/checkboxes', 1.8); $label = $option; diff --git a/views/default/input/radio.php b/views/default/input/radio.php index 924411aa8..60a2d10a6 100644 --- a/views/default/input/radio.php +++ b/views/default/input/radio.php @@ -3,6 +3,10 @@ * Elgg radio input * Displays a radio input field * + * @warning Passing integers as labels does not currently work due to a + * deprecated hack that will be removed in Elgg 1.9. To use integer labels, + * the labels must be character codes: 1 would be 1 + * * @package Elgg * @subpackage Core * @@ -42,7 +46,7 @@ if ($options && count($options) > 0) { $attributes = elgg_format_attributes($vars); // handle indexed array where label is not specified - // @deprecated 1.8 + // @deprecated 1.8 Remove in 1.9 if (is_integer($label)) { elgg_deprecated_notice('$vars[\'options\'] must be an associative array in input/radio', 1.8); $label = $option; |