a little cleanup of documentation and variable handling in input and output views

git-svn-id: http://code.elgg.org/elgg/trunk@3780 36083f99-b078-4883-b0ff-0f9b5a30f544

1 files changed, 7 insertions, 5 deletions

diff --git a/views/default/input/button.php b/views/default/input/button.php
index 0ad19a432..d6d3aec62 100644
--- a/views/default/input/button.php
+++ b/views/default/input/button.php
@@ -1,9 +1,6 @@
 <?php
 /**
  * Create a input button
- * Use this view or submit view for forms rather than creating a 
- * submit/reset button tag in the wild as it provides extra security 
- * which help prevent CSRF attacks.
  *
  * @package Elgg
  * @subpackage Core
@@ -13,7 +10,8 @@
  * @uses $vars['value'] The current value, if any
  * @uses $vars['js'] Any Javascript to enter into the input tag
  * @uses $vars['internalname'] The name of the input field
- * @uses $vars['type'] Submit or reset, defaults to submit.
+ * @uses $vars['internalid'] The id of the input field
+ * @uses $vars['type'] Submit, button, or reset, defaults to submit.
  * @uses $vars['src'] Src of an image
  *
  */
@@ -46,9 +44,13 @@ switch ($type) {
 }
 
 $value = htmlentities($vars['value'], ENT_QUOTES, 'UTF-8');
+
+$name = '';
 if (isset($vars['internalname'])) {
 	$name = $vars['internalname'];
 }
+
+$src = '';
 if (isset($vars['src'])) {
 	$src = "src=\"{$vars['src']}\"";
 }
@@ -57,4 +59,4 @@ if (strpos($src,$CONFIG->wwwroot)===false) {
 	$src = "";
 }
 ?>
-<input name="<?php echo $vars['internalname']; ?>" <?php if (isset($vars['internalid'])) echo "id=\"{$vars['internalid']}\""; ?> type="<?php echo $type; ?>" class="<?php echo $class; ?>" <?php echo $vars['js']; ?> value="<?php echo $value; ?>" <?php echo $src; ?> />
\ No newline at end of file
+<input name="<?php echo $name; ?>" <?php if (isset($vars['internalid'])) echo "id=\"{$vars['internalid']}\""; ?> type="<?php echo $type; ?>" class="<?php echo $class; ?>" <?php echo $vars['js']; ?> value="<?php echo $value; ?>" <?php echo $src; ?> />
\ No newline at end of file