Converted most forms to use elgg_view_form (therefore also moved the views to forms/*). Some views are left that _only_ do elgg_view_form, so I wonder if those should even be kept around.

git-svn-id: http://code.elgg.org/elgg/trunk@8127 36083f99-b078-4883-b0ff-0f9b5a30f544

3 files changed, 9 insertions, 3 deletions

diff --git a/views/default/core/account/login_box.php b/views/default/core/account/login_box.php
index 89612ef1b..c2d19f904 100644
--- a/views/default/core/account/login_box.php
+++ b/views/default/core/account/login_box.php
@@ -6,8 +6,6 @@
  * @subpackage Core
  */
 
-$form_body = elgg_view('forms/login');
-
 $login_url = elgg_get_site_url();
 if (elgg_get_config('https_login')) {
 	$login_url = str_replace("http:", "https:", $login_url);
@@ -17,7 +15,7 @@ if (elgg_get_config('https_login')) {
 <div id="login">
 <h2><?php echo elgg_echo('login'); ?></h2>
 	<?php
-		echo elgg_view('input/form', array('body' => $form_body, 'action' => "{$login_url}action/login"));
+		echo elgg_view_form('login', array('action' => "{$login_url}action/login"));
 	?>
 </div>
 <?php //@todo JS 1.8: no ?>
diff --git a/views/default/core/account/login_dropdown.php b/views/default/core/account/login_dropdown.php
index aa67c6756..a3fdab7ca 100644
--- a/views/default/core/account/login_dropdown.php
+++ b/views/default/core/account/login_dropdown.php
@@ -2,12 +2,18 @@
 /**
  * Elgg drop-down login form
  *
+ * @todo Forms 1.8: Convert to use elgg_view_form()
  */
 
 if (elgg_is_logged_in()) {
 	return true;
 }
 
+/**
+ * @todo forms/login should take a "forward_to" argument, or something similar
+ * Enter description here ...
+ * @var unknown_type
+ */
 $form_body = elgg_view('forms/login');
 $form_body .= "<input type='hidden' name='returntoreferer' value='true' />";
 
diff --git a/views/default/core/account/login_walled_garden.php b/views/default/core/account/login_walled_garden.php
index 0caaa3101..7b298a8c5 100644
--- a/views/default/core/account/login_walled_garden.php
+++ b/views/default/core/account/login_walled_garden.php
@@ -13,6 +13,7 @@ if (elgg_get_config('https_login')) {
 ?>
 <h2><?php echo elgg_echo('login'); ?></h2>
 <?php
+	//@todo Forms 1.8: Convert to use elgg_view_form()
 	echo elgg_view('input/form', array('body' => $form_body, 'action' => "{$login_url}action/login"));
 	echo elgg_view('login/extend'); // view for plugins to extend
 ?>
@@ -46,6 +47,7 @@ __HTML;
 	<div id="hiddenform_body" class="clearfix">
 		<h2><?php echo elgg_echo('user:password:lost'); ?></h2>
 		<?php
+			//@todo Forms 1.8: Use elgg_view_form()
 			echo elgg_view('input/form', array(
 				'action' => "action/user/requestnewpassword",
 				'body' => $lostpassword_form_body