cleaned up the messageboard plugin further

git-svn-id: http://code.elgg.org/elgg/trunk@8516 36083f99-b078-4883-b0ff-0f9b5a30f544

2 files changed, 17 insertions, 30 deletions

diff --git a/mod/messageboard/views/default/widgets/messageboard/content.php b/mod/messageboard/views/default/widgets/messageboard/content.php
index 7ec3e5d4e..04dbb00d2 100644
--- a/mod/messageboard/views/default/widgets/messageboard/content.php
+++ b/mod/messageboard/views/default/widgets/messageboard/content.php
@@ -2,16 +2,11 @@
 /**
  * Elgg messageboard widget view
  *
- *
- * @package ElggMessageBoard
  */
 
 $owner = elgg_get_page_owner_entity();
-$num_display = 5;
 
-if (isset($vars['entity']->num_display)) {
-	$num_display = $vars['entity']->num_display;
-}
+$num_display = $vars['entity']->num_display;
 
 if (elgg_is_logged_in()) {
 	echo elgg_view_form('messageboard/add', array('name' => 'elgg-messageboard'));
@@ -22,7 +17,7 @@ $options = array(
 	'guid' => $owner->getGUID(),
 	'limit' => $num_display,
 	'pagination' => false,
-	'reverse_order_by' => true
+	'reverse_order_by' => true,
 );
 
 echo elgg_list_annotations($options);
@@ -35,5 +30,5 @@ if ($owner instanceof ElggGroup) {
 
 echo elgg_view('output/url', array(
 	'href' => $url,
-	'text' => elgg_echo('messageboard:viewall')
+	'text' => elgg_echo('messageboard:viewall'),
 ));
\ No newline at end of file
diff --git a/mod/messageboard/views/default/widgets/messageboard/edit.php b/mod/messageboard/views/default/widgets/messageboard/edit.php
index 2157da6c4..74848f832 100644
--- a/mod/messageboard/views/default/widgets/messageboard/edit.php
+++ b/mod/messageboard/views/default/widgets/messageboard/edit.php
@@ -1,30 +1,22 @@
 <?php
 /**
- * Elgg message board widget edit view
- *
- * @package ElggMessageBoard
+ * Messageboard widget edit view
  */
 
-$num_display = 5;
-
-if (isset($vars['entity']->num_display)) {
-	$num_display = $vars['entity']->num_display;
+// set default value
+if (!isset($vars['entity']->num_display)) {
+	$vars['entity']->num_display = 5;
 }
 
-?>
-<p>
-	<?php echo elgg_echo("messageboard:num_display"); ?>:
-	<select name="params[num_display]">
-<?php
-$options = array(1,2,3,4,5,6,7,8,9,10);
-foreach ($options as $option)  {
-	$selected = '';
-	if ($num_display == $option) {
-		$selected = "selected='selected'";
-	}
+$params = array(
+	'name' => 'params[num_display]',
+	'value' => $vars['entity']->num_display,
+	'options' => array(1, 2, 3, 4, 5, 6, 7, 8, 9, 10),
+);
+$dropdown = elgg_view('input/dropdown', $params);
 
-	echo "	<option value='{$option}' $selected >{$option}</option>\n";
-}
 ?>
-	</select>
-</p>
\ No newline at end of file
+<div>
+	<?php echo elgg_echo('messageboard:num_display'); ?>:
+	<?php echo $dropdown; ?>
+</div>