Marcus Povey <marcus@dushka.co.uk>

* Removed count based on this conversation:

[10:05:38] … basically, if you add an item, you need to create a tag entry in the metastrings table (as discussed yesterday)
[10:05:56] … if you then delete the item, that leaves a tag
[10:06:07] … if you want to delete the tag when nothing references it
[10:06:11] … it needs a counter
[10:06:29] … which means for every add and delete query you need to check for and sometimes update this counter
[10:06:36] … making three queries for every one
[10:06:47] … but if you don't do that the meta strings table grows over time
[10:06:54] … making it space inefficient
[10:07:03] … so, which do you do?
[10:10:31] … ?
[10:10:43] … i'd be tempted to not delete
[10:10:58] … because the multiple queries will be a pain for everyone all the time
[10:11:05] … and storage costs are cheap
[10:11:32] Ben Werdmuller: I would be very tempted to do the same
[10:11:35] … so let's do that :)
[10:11:36] Marcus Povey: maybe we could write an admin script to clean up or something
[10:11:45] Ben Werdmuller: exactly, we could clean up on a cron if people really want
[10:11:59] … but for now, let's just go with the growing tag cloud

git-svn-id: https://code.elgg.org/elgg/trunk@149 36083f99-b078-4883-b0ff-0f9b5a30f544

1 files changed, 0 insertions, 1 deletions

diff --git a/engine/schema/mysql.sql b/engine/schema/mysql.sql
index 18e7b6eb0..0170b5aef 100644
--- a/engine/schema/mysql.sql
+++ b/engine/schema/mysql.sql
@@ -231,7 +231,6 @@ CREATE TABLE `prefix_metadata` (
 CREATE TABLE `prefix_metastrings` (

 	`id` int(11) NOT NULL auto_increment,

 	`value` text NOT NULL,

-	`count` int(11) default 1,

 	

 	PRIMARY KEY (`id`),

 	UNIQUE KEY `value`