From 1f71bffdbec1c90bb88c2bae62589180348651a1 Mon Sep 17 00:00:00 2001 From: Jamie McClelland Date: Tue, 10 May 2011 17:18:31 -0400 Subject: sort -n doesn't properly sort hex values - resulting in duplicate mac address if the last mac address created ends in 0a (we get 09 as the last sorted address, hence 0a gets created again). --- kvm-creator | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kvm-creator b/kvm-creator index 9e2ad41..2428000 100755 --- a/kvm-creator +++ b/kvm-creator @@ -26,7 +26,7 @@ UDEV_RULES_FILE="/etc/udev/rules.d/92-kvm_creator-%s.rules" ls /etc/sv/kvm/* &> /dev/null if [ "$?" -eq 0 ]; then TAP="${5:-tap$(( $( cat /etc/sv/kvm/*/env/TAP | sed 's/^tap//' | sort -n | tail -n 1 ) + 1 ))}" - MAC="${6:-$(printf "%s:%02x" "$(cat /etc/sv/kvm/*/env/MAC | sort | head -n1 | cut -f 1-5 -d: )" "$(( 0x$( cat /etc/sv/kvm/*/env/MAC | cut -f 6 -d: | sort -n | tail -n 1 ) + 1 ))" )}" + MAC="${6:-$(printf "%s:%02x" "$(cat /etc/sv/kvm/*/env/MAC | sort | head -n1 | cut -f 1-5 -d: )" "$(( 0x$( cat /etc/sv/kvm/*/env/MAC | cut -f 6 -d: | sort | tail -n 1 ) + 1 ))" )}" else TAP=tap0 # use a locally-administered MAC address: -- cgit v1.2.3