diff options
| author | intrigeri <intrigeri@boum.org> | 2010-01-08 23:40:23 +0100 |
|---|---|---|
| committer | intrigeri <intrigeri@boum.org> | 2010-01-08 23:40:23 +0100 |
| commit | 47313bca65de105145f2168538b294a9bcc0e98d (patch) | |
| tree | 8fcc10551cae627e432cb9366608cf2c935817e0 /handlers/ldap.in | |
| parent | 49bfd02bd3ee6eccc2eaa0a7c668c46b4a15af0a (diff) | |
| download | backupninja-47313bca65de105145f2168538b294a9bcc0e98d.tar.gz backupninja-47313bca65de105145f2168538b294a9bcc0e98d.tar.bz2 | |
ldap,mysql,pgsql: use bash pipefail option so that failed dumps are reported as such
This should fix Redmine bug #1340.
This option makes pipelines return as status the value of the last (rightmost)
command to exit with a non-zero status, or zero if all commands exit
successfully. See bash(1) for details.
E.g. this prevents the following from exiting with status 0 (!) if pg_dumpall
fails:
pg_dumpall | gzip
Diffstat (limited to 'handlers/ldap.in')
| -rw-r--r-- | handlers/ldap.in | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/handlers/ldap.in b/handlers/ldap.in index 853cefb..fda24d0 100644 --- a/handlers/ldap.in +++ b/handlers/ldap.in @@ -91,7 +91,7 @@ if [ "$ldif" == "yes" ]; then execstr="$execstr > $dumpdir/$dbsuffix.ldif" fi debug "$execstr" - output=`su root -c "$execstr" 2>&1` + output=`su root -c "set -o pipefail ; $execstr" 2>&1` code=$? if [ "$code" == "0" ]; then debug $output |